Last modified: 2009-06-23 01:21:42 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T21219, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 19219 - Extra whitespace at top of page
Extra whitespace at top of page
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Parser (Other open bugs)
unspecified
All All
: Normal minor with 3 votes (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-06-15 16:50 UTC by Robert Rohde
Modified: 2009-06-23 01:21 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Screenshot of bad & good output w/ giant space of doom (11.30 KB, image/png)
2009-06-23 01:21 UTC, Brion Vibber
Details

Description Robert Rohde 2009-06-15 16:50:32 UTC
The recent software update seems to have added a blank whitespace between the Article, Discussion, etc... tabs and the page title.  The appearance is as if the entire page text has been pushed down some within its bounding box.  This is visible on both IE and Firefox and roughly the height of a normal line of text.
Comment 1 Gurch 2009-06-15 17:45:12 UTC
Affects monobook skin only on all Wikimedia wikis.

This is the change which did it:

r1=50702&r2=51081">http://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/skins/monobook/main.css?r1=50702&r2=51081

The change has no affect on the default appearence because by default there is no sitenotice div on the page. On Wikimedia wikis, the sitenotice div is always there, just empty when there is no notice. Thus this change added 0.9em of blank space. The "corrected" line should never have been there in the first place.

Fix is to remove that line.
Comment 2 Brion Vibber 2009-06-23 01:18:35 UTC
Change appears to have been made due to mistaken impression of what the code did...

Explanation: "padding: 0 .9em" sets the top/bottom padding to 0 and the left/right padding to 0.9em.

"padding-top: 0.9em" sets the top padding to 0.9em and leaves the top/left/right padding unset -- totally different.

I'm changing it to "padding: 0 0.9em" to make it clearer that it's not a mistake for "0.9". Fixed in r52299.
Comment 3 Brion Vibber 2009-06-23 01:21:42 UTC
Created attachment 6251 [details]
Screenshot of bad & good output w/ giant space of doom

To illustrate the problem for future generations.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links