Last modified: 2009-06-17 23:45:17 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T21214, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 19214 - Bugs connected with FlaggedRevs
Bugs connected with FlaggedRevs
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
FlaggedRevs (Other open bugs)
unspecified
All All
: Normal enhancement with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-06-15 15:15 UTC by Leinad
Modified: 2009-06-17 23:45 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Leinad 2009-06-15 15:15:00 UTC
After code update occurred following bugs:
1. edit made by editor and marked automatically as sighted still display with red exclamation mark (also on RecentChanges)
2. disappeared link "(review)" (a few months ago it was enabled, look bug16636)
Comment 1 Aaron Schulz 2009-06-15 20:15:18 UTC
1) fixed in r51920
Comment 2 Leinad 2009-06-15 20:16:17 UTC
3. Newly created pages by editor don't be automatically marked as reviewed.
Comment 3 Aaron Schulz 2009-06-15 20:19:28 UTC
*** Bug 19206 has been marked as a duplicate of this bug. ***
Comment 4 Aaron Schulz 2009-06-15 20:43:59 UTC
(In reply to comment #2)
> 3. Newly created pages by editor don't be automatically marked as reviewed.

Fixed in r51925
Comment 5 Alexey Bobyakov 2009-06-15 20:48:00 UTC
4. Stable versions of pages are shown by default even though the pages are not stabilized. 
Comment 6 Aaron Schulz 2009-06-15 20:50:12 UTC
(In reply to comment #5)
> 4. Stable versions of pages are shown by default even though the pages are not
> stabilized. 

What wiki is this?
Comment 7 Alexey Bobyakov 2009-06-15 20:51:44 UTC
ruwiki
Comment 8 Aaron Schulz 2009-06-15 20:58:28 UTC
(In reply to comment #0)
> After code update occurred following bugs:
> 1. edit made by editor and marked automatically as sighted still display with
> red exclamation mark (also on RecentChanges)
> 2. disappeared link "(review)" (a few months ago it was enabled, look bug16636)

2) Fixed in r51929
Comment 9 Aaron Schulz 2009-06-15 21:25:54 UTC
(In reply to comment #7)
> ruwiki

flaggedrevsstable preference default was wrong, fixed to "false" in r51931
Comment 10 Anatoliy Goncharov 2009-06-15 21:58:13 UTC
Edits made by bots after sighted edit are not autosighted too (for example: http://uk.wiktionary.org/w/index.php?title=%E5%B8%82&diff=86435&oldid=86339 )
Comment 11 Aaron Schulz 2009-06-15 22:00:03 UTC
(In reply to comment #10)
> Edits made by bots after sighted edit are not autosighted too (for example:
> http://uk.wiktionary.org/w/index.php?title=%E5%B8%82&diff=86435&oldid=86339 )

See bug 19207. These really should be separate.
Comment 12 Leinad 2009-06-15 22:01:49 UTC
(In reply to comment #10)
> Edits made by bots after sighted edit are not autosighted too (for example:
> http://uk.wiktionary.org/w/index.php?title=%E5%B8%82&diff=86435&oldid=86339 )
> 

This issue has been reported in bug19207.
Comment 14 Leinad 2009-06-16 09:50:39 UTC
(In reply to comment #13)
> 5. Some reviewed edits are shown as unreviewed in a watchlist. For example:
> http://ru.wikipedia.org/w/api.php?action=query&prop=revisions&titles=Вооружённый%20конфликт%20в%20Южной%20Осетии%20(2008)&rvprop=user|comment|flags|flagged|ids&rvstartid=16435729&rvlimit=1
> .

From my observation, only edits made between r51863 and r51943 have these damage. After syncing revision with correction 1)-4) it works  correctly.
Comment 15 p858snake 2009-06-16 09:57:40 UTC
Changing Product: Wikimedia → Mediawiki extensions
Changing Component: WikiBugs → Flagged Revs
Reason: The wikibugs component is designed for the I.R.C. bot[1].

[1]. https://bugzilla.wikimedia.org/describecomponents.cgi?product=Wikimedia
Comment 16 Leinad 2009-06-16 10:04:40 UTC
6. (connected with issue 1.) Newly created pages by editor are marking automatically as sighted, but:
- on RC and Watchlist still display with red exclamation mark (only with one version in history, after next one edition red exclamation mark disappear)
- on [[Special:NewPages]] still display on yellow background (only with one version in history...)
Comment 17 Alexey Bobyakov 2009-06-16 10:06:33 UTC
This is exactly my (5) issue, with more details.
Comment 18 Aaron Schulz 2009-06-16 19:45:03 UTC
(In reply to comment #14)
> (In reply to comment #13)
> > 5. Some reviewed edits are shown as unreviewed in a watchlist. For example:
> > http://ru.wikipedia.org/w/api.php?action=query&prop=revisions&titles=Вооружённый%20конфликт%20в%20Южной%20Осетии%20(2008)&rvprop=user|comment|flags|flagged|ids&rvstartid=16435729&rvlimit=1
> > .
> From my observation, only edits made between r51863 and r51943 have these
> damage. After syncing revision with correction 1)-4) it works  correctly.

Yes, the fix doesn't retroactively mark off some of the errant RC items.
Comment 19 Aaron Schulz 2009-06-16 19:56:39 UTC
(In reply to comment #16)
> 6. (connected with issue 1.) Newly created pages by editor are marking
> automatically as sighted, but:
> - on RC and Watchlist still display with red exclamation mark (only with one
> version in history, after next one edition red exclamation mark disappear)
> - on [[Special:NewPages]] still display on yellow background (only with one
> version in history...)

Can't reproduce locally.
Comment 20 Leinad 2009-06-16 20:23:18 UTC
(In reply to comment #19)
> (In reply to comment #16)
> > 6. (connected with issue 1.) Newly created pages by editor are marking
> > automatically as sighted, but:
> > - on RC and Watchlist still display with red exclamation mark (only with one
> > version in history, after next one edition red exclamation mark disappear)
> > - on [[Special:NewPages]] still display on yellow background (only with one
> > version in history...)
> 
> Can't reproduce locally.
> 

Sorry, but I don't understand...

Red exclamation mark means unreviewed pages or outdated reviewed pages. When editor create article, revision has mark "[automatically sighted]", so on Watchlist and RC this page shouldn't be show with red exclamation mark.

Am I mistaken?
Comment 21 Alexey Bobyakov 2009-06-17 08:30:02 UTC
Alas, some autoeditors edits are still not marked as autoreviewed, see http://ru.wikipedia.org/w/api.php?action=query&prop=revisions&titles=Харлем&rvprop=user|comment|flags|flagged|ids&rvstartid=16464709&rvlimit=1, for example.
Comment 22 Leinad 2009-06-17 17:12:23 UTC
(In reply to comment #21)
> Alas, some autoeditors edits are still not marked as autoreviewed, see
> http://ru.wikipedia.org/w/api.php?action=query&prop=revisions&titles=Харлем&rvprop=user|comment|flags|flagged|ids&rvstartid=16464709&rvlimit=1,
> for example.
> 

And also other type of "autoeditor" have the same problem... (ru.wiki has users with special right - bug15478, pl.wiki has autopromoted users with 'autoreview' permission - r47252).

Example: http://pl.wikipedia.org/wiki/Dyskusja_wikipedysty:Mathiasrex - after code update, user's edits aren't marking as autoreviewed.
Comment 23 Aaron Schulz 2009-06-17 20:38:35 UTC
(In reply to comment #20)
> (In reply to comment #19)
> > (In reply to comment #16)
> > > 6. (connected with issue 1.) Newly created pages by editor are marking
> > > automatically as sighted, but:
> > > - on RC and Watchlist still display with red exclamation mark (only with one
> > > version in history, after next one edition red exclamation mark disappear)
> > > - on [[Special:NewPages]] still display on yellow background (only with one
> > > version in history...)
> > 
> > Can't reproduce locally.
> > 
> Sorry, but I don't understand...
> Red exclamation mark means unreviewed pages or outdated reviewed pages. When
> editor create article, revision has mark "[automatically sighted]", so on
> Watchlist and RC this page shouldn't be show with red exclamation mark.
> Am I mistaken?

I'm refering to my test wiki.
Comment 24 Aaron Schulz 2009-06-17 21:00:55 UTC
I can see the yellow NP line issue on dewiki, ugh
Comment 25 Aaron Schulz 2009-06-17 21:13:10 UTC
6) Fixed in r52075 (slave lag issue)
Comment 26 Leinad 2009-06-17 21:56:27 UTC
(In reply to comment #22)
> (In reply to comment #21)
> > Alas, some autoeditors edits are still not marked as autoreviewed, see
> > http://ru.wikipedia.org/w/api.php?action=query&prop=revisions&titles=Харлем&rvprop=user|comment|flags|flagged|ids&rvstartid=16464709&rvlimit=1,
> > for example.
> > 
> 
> And also other type of "autoeditor" have the same problem... (ru.wiki has users
> with special right - bug15478, pl.wiki has autopromoted users with 'autoreview'
> permission - r47252).
> 
> Example: http://pl.wikipedia.org/wiki/Dyskusja_wikipedysty:Mathiasrex - after
> code update, user's edits aren't marking as autoreviewed.
> 

Hmmm... You overlooked above issue - #7.
Comment 27 Leinad 2009-06-17 22:04:14 UTC
Sorry, but I find next issue...

8. On page [[Special:ListGroupRights]] in bot group lack info about 'autoreview' permission.
Comment 28 Aaron Schulz 2009-06-17 22:09:36 UTC
As I said above, any other issue should go in their own bug. This is getting harder and harder to read.
Comment 29 Leinad 2009-06-17 23:26:00 UTC
:(
You are inconsistent, first you mark bug19206 as duplicate of this, a than you didn't resolve this problem, because you are complaining about too many issues.

I've reopened bug19206 and report new bug19269.
Comment 30 Aaron Schulz 2009-06-17 23:45:17 UTC
(In reply to comment #29)
> :(
> You are inconsistent, first you mark bug19206 as duplicate of this, a than you
> didn't resolve this problem, because you are complaining about too many issues.
> I've reopened bug19206 and report new bug19269.

I didn't request that other issues be raised as separate bugs until comment #11; I should have said that sooner, but was only expecting 2-3 items would be posted here. REOPENing is fine.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links