Last modified: 2009-06-17 13:54:51 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T21207, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 19207 - Bot edits should be marked automatically as sighted
Bot edits should be marked automatically as sighted
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
FlaggedRevs (Other open bugs)
unspecified
All All
: Highest critical with 7 votes (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-06-15 12:27 UTC by Leinad
Modified: 2009-06-17 13:54 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Leinad 2009-06-15 12:27:36 UTC
After code update, projects with FlaggedRevs has quite big problem... edits made by bots do not be marked automaticly as sighted.
Comment 1 Tisza Gergő 2009-06-15 18:36:19 UTC
Special treatment of bots was apparently removed from the code in r48482: r1=48481&r2=48482">http://svn.wikimedia.org/viewvc/mediawiki/trunk/extensions/FlaggedRevs/FlaggedRevs.hooks.php?view=diff&r1=48481&r2=48482
Comment 2 Aaron Schulz 2009-06-15 19:36:10 UTC
checkAutoPromote() should do this already
Comment 3 Tisza Gergő 2009-06-15 19:52:17 UTC
In any case, I can confirm that bot edits are not autosighted. See for example [[hu:Special:Contributions/TXiKiBoT]] (which had bot flag on hu.wp for years): most of the lines without background color are edits where the bot edited a sighted page, and turned it into a draft.
Comment 4 Leinad 2009-06-15 19:52:58 UTC
(In reply to comment #2)
> checkAutoPromote() should do this already
> 

Can you check whether it works? I don't see any special page with log, so I don't know how it check... ;/

On pl.wiki we temporarily grant bots editor flag, but it isn't a solution.
Comment 5 Anatoliy Goncharov 2009-06-15 22:05:45 UTC
(In reply to comment #3)
> In any case, I can confirm that bot edits are not autosighted. See for example
> [[hu:Special:Contributions/TXiKiBoT]] (which had bot flag on hu.wp for years):
> most of the lines without background color are edits where the bot edited a
> sighted page, and turned it into a draft.
> 

And this: http://uk.wiktionary.org/w/index.php?title=%E5%B8%82&diff=86435&oldid=86339 is not autosighted too
Comment 6 Aaron Schulz 2009-06-16 02:00:14 UTC
Is this still occuring?
Comment 7 Gondnok 2009-06-16 04:53:23 UTC
Yes (at least on huwiki).
Comment 8 Leinad 2009-06-16 09:06:42 UTC
(In reply to comment #7)
> Yes (at least on huwiki).
> 

Also on plwiki and dewiki ;/
Comment 9 pgrawehr 2009-06-16 15:03:06 UTC
Setting prio to high, this needs fixing ASAP. Bots are causing thousands of pages to become unsighted on dewiki. We also have to many bots to either give them all editor rights or block them. 
Comment 10 Leinad 2009-06-16 16:54:02 UTC
Tim added to local conf "$wgGroupPermissions['bot']['review'] = true;" and now it works (previously was "$wgGroupPermissions['bot']['autoreview'] = true;" and it didn't work).
Comment 11 pgrawehr 2009-06-16 18:42:18 UTC
(In reply to comment #10)
> Tim added to local conf "$wgGroupPermissions['bot']['review'] = true;" and now
> it works (previously was "$wgGroupPermissions['bot']['autoreview'] = true;" and
> it didn't work).

Yea, I asked him to do this as a quick workaround, because the problem was really getting serious, at least on dewiki. Obviously, this is not a solution, but it shows rather clearly that the problem has something to do with the fact that the "autoreview" feature is broken. A fix is being worked on. 
Comment 12 Aaron Schulz 2009-06-16 21:03:44 UTC
Fixed in r52003
Comment 13 Tim Starling 2009-06-17 13:54:51 UTC
Live now, removed review permission workaround.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links