Last modified: 2011-10-29 13:21:42 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T21186, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 19186 - Special:UserLogin's title on Special:SpecialPages should not say "create account" if the user cannot create an account


Summary:	Special:UserLogin's title on Special:SpecialPages should not say "create acco...

Status:	RESOLVED FIXED

Product:	MediaWiki
Classification:	Unclassified
Component:	Special pages (Other open bugs)
Version:	1.16.x
Hardware:	All All

Importance:	Low enhancement (vote)
Target Milestone:	---
Assigned To:	Nobody - You can work on this!

URL:
Whiteboard:
Keywords:	patch, patch-need-review

Duplicates:	24463 (view as bug list)
Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2009-06-14 07:40 UTC by Dan Jacobson
Modified:	2011-10-29 13:21 UTC (History)
CC List:	5 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Patch to fix Special:SpecialPages (1.89 KB, patch) 2011-04-22 05:16 UTC, michael	Details
Add an attachment (proposed patch, testcase, etc.)

Description Dan Jacobson 2009-06-14 07:40:26 UTC

In specials/SpecialSpecialpages.php,
# Login/create account
>'Userlogin'     => array( 'SpecialPage', 'Userlogin' ),
>'CreateAccount' => array( 'SpecialRedirectToSpecial', ...
Well, just as is already solved in SkinTemplate.php:
>$loginlink = $wgUser->isAllowed( 'createaccount' )
>	? 'nav-login-createaccount'
>	: 'login';
please first check if they really can create an account, before
advertising to do so.

Comment 1 Happy-melon 2009-06-15 20:24:19 UTC

Could you clarify the issue here?  There's a check in SkinTemplate to switch between a "login/createaccount" link and a simple "login" link if the user can't create an account; I assume that the bug is that this check is not done elsewhere; but where, exactly?

Comment 2 Gurch 2009-06-16 15:09:39 UTC

(In reply to comment #1)
> I assume that the bug is that this check is not done
> elsewhere; but where, exactly?

I think he means on [[Special:SpecialPages]], where "Log in / create account" is one of the pages listed.

Comment 3 Alexandre Emsenhuber [IAlex] 2009-08-21 08:45:02 UTC

(In reply to comment #2) 
> I think he means on [[Special:SpecialPages]], where "Log in / create account"
> is one of the pages listed.

In this case, this bug is a duplicate of bug 20115.

Comment 4 Dan Jacobson 2009-08-21 10:06:27 UTC

> In this case, this bug is a duplicate of bug 20115
No.

Comment 5 Alexandre Emsenhuber [IAlex] 2009-08-21 10:14:12 UTC

So you'll need to explain what you want *exactely*, since for now I don't see the difference with bug 20115.

Comment 6 Dan Jacobson 2009-08-21 10:23:12 UTC

(In reply to comment #5)
Sorry, I should have reiterated that bug 20115 is talking about the HTML <head> part of Special:UserLogin, while this bug is talking about what one sees on Special:Specialpages.

Comment 7 Alexandre Emsenhuber [IAlex] 2009-08-21 10:28:53 UTC

clarified summary according to comment #6.

Comment 8 Karun 2010-01-02 10:07:50 UTC

It looks like this bug has already been fixed in the version of the wiki i am using.

Comment 9 Dan Jacobson 2010-01-02 13:39:03 UTC

As of r60557 one still sees offers to "sign up", "create account",
although there is no way for the user to create an account, as we have turned that off
in LocalSettings.php. So the user sees links which will just lead to disappointment.
So don't mention creating accounts here if not possible.

$ w3m -dump http://abj.jidanni.org/index.php?title=Special:SpecialPages |
egrep 'sign up|create'
Login / sign up
  • Log in / create account

Comment 10 Chad H. 2010-07-20 19:01:11 UTC

*** Bug 24463 has been marked as a duplicate of this bug. ***

Comment 11 michael 2011-04-22 03:23:40 UTC

On a related note the group name shows "Login / sign up" instead of login on Special:SpecialPages.

Comment 12 michael 2011-04-22 05:16:58 UTC

Created attachment 8439 [details]
Patch to fix Special:SpecialPages

This patch fixes both messages.

Comment 13 Alexandre Emsenhuber [IAlex] 2011-10-29 13:21:42 UTC

Fixed in r101260.

Note You need to log in before you can comment on or make changes to this bug.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links