Last modified: 2010-05-15 15:32:53 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 1915 - Edit link URL gets "oldid" from page URL instead of actual id, where page URL has "oldid" and "direction" values
Edit link URL gets "oldid" from page URL instead of actual id, where page URL...
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
1.4.x
All All
: Normal major with 5 votes (vote)
: ---
Assigned To: Nobody - You can work on this!
http://meta.wikimedia.org/w/index.php...
:
: 3458 3674 4079 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2005-04-18 06:09 UTC by Martin Vogel
Modified: 2010-05-15 15:32 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Fix for HEAD (5.24 KB, patch)
2005-12-01 09:47 UTC, Brion Vibber
Details

Description Martin Vogel 2005-04-18 06:09:35 UTC
If you go to the history of a page, and click on the version (15:52) you will see this one. If you 
then click on "Newer revision", you will see the Version (18:17). And if you now click on edit, you 
will not edit the Version (18:17), but version (15:52). 

The same bug, if you go to "Older revision".

Martin Vogel
Comment 1 Brion Vibber 2005-04-18 06:12:00 UTC
Please provide a link to the exact page on the exact wiki you are referring to, or exact step-by-
step directions to reproduce the problem on a fresh mediawiki installation.

Can you also explain what this has to do with Wikimedia's domain name servers? This bug 
appears to be filed on the wrong component.
Comment 2 Zigger 2005-06-08 14:19:43 UTC
I've reproduced this, and identified the problem somewhat, using
[[meta:Trophees_du_Libre]] as an example under v1.4.5. It also occurs in 1.5alpha2.

After following a "Newer revision" link from
http://meta.wikimedia.org/w/index.php?title=Trophees_du_Libre&oldid=2803 , we
get a URL like
http://meta.wikimedia.org/w/index.php?title=Trophees_du_Libre&direction=next&oldid=2803
.

The edit link is now
http://meta.wikimedia.org/w/index.php?title=Trophees_du_Libre&action=edit&oldid=2803
, and seems to be based on the oldid value from the URL, instead of the current
revision id of 4529.

The current revision id is used correctly in the "Older revision" and "Newer
revision" links correctly, and the displayed revision timestamp matches the
retrieved revision.  It's just the wrong revision.
Comment 3 Dashiva 2005-06-08 14:35:55 UTC
I thought the previous explanation was a little vague.

You are viewing revision A. The next and previous links use oldid=A and direction=prev/next.
You click one of the links.
Now you're viewing revision B. The next and previous links use oldid=B and direction=prev/next.

Problem: oldid in the url is A
From SkinTemplate.php: $oldid = $wgRequest->getVal( 'oldid' );
Thus the edit button uses oldid=A and you get the revious before/after the one you were watching.
Comment 4 Zigger 2005-09-14 12:47:37 UTC
*** Bug 3458 has been marked as a duplicate of this bug. ***
Comment 5 lɛʁi לערי ריינהארט 2005-10-06 19:18:59 UTC
please see also

bug 3630: Older revision is triggered by oldid value not by date - probably
historical issue
Comment 6 Brion Vibber 2005-10-10 21:52:56 UTC
*** Bug 3674 has been marked as a duplicate of this bug. ***
Comment 7 Brion Vibber 2005-11-25 20:18:47 UTC
*** Bug 4079 has been marked as a duplicate of this bug. ***
Comment 8 Jason Lee, AllyUnion 2005-11-28 02:09:56 UTC
Still a problem, as the edit this page apparently gets from the url rather that
report the previous id;

However, if you add the &direction=prev to the url, it seems to fix it.

From:
http://en.wikipedia.org/w/index.php?title=Template:Did_you_know&direction=prev&oldid=25242342

Edit this page points to:
http://en.wikipedia.org/w/index.php?title=Template:Did_you_know&action=edit&oldid=25242342

Can be easily fixed if you add the &direction=prev
----

http://en.wikipedia.org/w/index.php?title=Template:Did_you_know&action=edit&direction=prev&oldid=25242342
Comment 9 Jason Lee, AllyUnion 2005-11-28 19:48:14 UTC
Bug 4035 is related to this bug
Comment 10 Brion Vibber 2005-12-01 09:47:19 UTC
Created attachment 1120 [details]
Fix for HEAD

* (bug 1915) Fix edit links when 'direction' used with 'oldid';
  using revision ID reported via OutputPage; Skin::editUrlOptions()
* Remove obsolete 'redirect=no' on some edit links
* Include oldid for the second revision on edit link on diff view

Committing this; it relies on other recently made changes on CVS HEAD which
propagate the actual viewed revision ID up to OutputPage, so won't apply on
REL1_5.
Comment 11 Daniel Kinzler 2005-12-01 18:56:49 UTC
Apperently, the fix for this bug causes an oldid to be included in the edit link
even if you are viewing the current version. I.e. if you click "edit" on a
"normal" page view, you will edit the revision that was current when the page
was rendered, not the version that is current when "edit" is clicked.

This may or may not be The Right Thing... I seems to confuse people and cvause
unintentional reverts. This is especially true for past cahning pages of course
- like the village pump, etc. 

Please re-think this, people in the de:wp are complaining. See
[[de:Wikipedia:Fragen_zur_Wikipedia#Was_ist_denn_jetzt_los??]] (german) for
example. Apperently, this needs further discussion. re-opening.
Comment 12 Ævar Arnfjörð Bjarmason 2005-12-01 19:10:52 UTC
(In reply to comment #11)
> Apperently, the fix for this bug causes an oldid to be included in the edit link
> even if you are viewing the current version. I.e. if you click "edit" on a
> "normal" page view, you will edit the revision that was current when the page
> was rendered, not the version that is current when "edit" is clicked.

Changed this back to how it was, marking this as FIXED.
Comment 13 Brion Vibber 2005-12-01 19:47:51 UTC
I'm pretty sure I tested that, whoops...

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links