Last modified: 2009-06-17 11:50:49 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T21135, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 19135 - Getting database error when trying to save filter
Getting database error when trying to save filter
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
AbuseFilter (Other open bugs)
unspecified
All All
: Normal enhancement with 1 vote (vote)
: ---
Assigned To: Andrew Garrett
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-06-08 20:50 UTC by Melancholie
Modified: 2009-06-17 11:50 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Melancholie 2009-06-08 20:50:21 UTC
On alswiki, I am getting a database error when trying to save a filter containing a umlaut or a regex:

lcase(added_lines) contains "fööbar" |
lcase(added_lines) rlike "foo[^ ]bar"

Error message is:

A database query syntax error has occurred. This may indicate a bug in the software. The last attempted database query was:

    (SQL query hidden)

from within function "AbuseFilterViewEdit::show". MySQL returned error "1054: Unknown column 'af_global' in 'field list' (10.0.6.21)".
Comment 1 Melancholie 2009-06-08 21:01:08 UTC
Suddenly applies for all filters there, not just for those containing an umlaut or regex. Error occurs not always, but in, let's say, 9 of 10 attempts.
Comment 2 Roan Kattouw 2009-06-08 21:11:17 UTC
Looks like a schema change has slipped through the cracks here. Could this be related to Tim's running schema changes earlier today?
Comment 3 Andrew Garrett 2009-06-08 21:27:25 UTC
I've looked at the error logs and I can find the error on alswiki, from lots and lots of different servers.

It's a bit strange, the code isn't supposed to be updated on those servers.
Comment 4 mwpnl 2009-06-09 13:32:10 UTC
The same problem occurs on nl-wikipedia. We cannot commit any changes to filters.
Comment 5 mwpnl 2009-06-09 13:36:45 UTC
The error on nl-wikipedia:
Error in function "AbuseFilterViewEdit::show”.
MySQL returned  “1054: Unknown column 'af_global' in 'field list' (10.0.6.23)

Best regards,
Mark Wesbeek
Comment 6 Tim Starling 2009-06-09 13:54:50 UTC
Did a live hack on Wikimedia to fix. I suggest implementing a permanent fix along the lines of using an explicit field list for any INSERT queries instead of trusting the DB. Also you shouldn't be selecting data from a slave and then saving it back to the master, that could lead to some nasty unintended reversions if there's any replication lag.
Comment 7 Andrew Garrett 2009-06-17 11:50:49 UTC
I've sorted this out in r52048.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links