Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T21112, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 19112 - check $wgUseExternalEditor, $wgExternalDiffEngine before showing Preference

Summary:	check $wgUseExternalEditor, $wgExternalDiffEngine before showing Preference

Status: RESOLVED FIXED Product: MediaWiki Classification: Unclassified Component: User preferences (Other open bugs) Version: 1.16.x Hardware: All All Importance: Normal minor (vote) Target Milestone: --- Assigned To: Nobody - You can work on this! URL: Whiteboard: Keywords: patch, patch-reviewed Depends on: Blocks:   Show dependency tree / graph		Reported: 2009-06-07 00:08 UTC by Dan Jacobson Modified: 2009-06-09 23:01 UTC (History) CC List: 1 user (show) innocentkiller See Also: Web browser: --- Mobile Platform: --- Assignee Huggle Beta Tester: ---

Attachments externaleditor, externaldiff checks (1.24 KB, patch) 2009-06-07 00:08 UTC, Dan Jacobson Details Add an attachment (proposed patch, testcase, etc.)

Description Dan Jacobson 2009-06-07 00:08:21 UTC Created attachment 6205 [details] externaleditor, externaldiff checks In this patch we add checks for $wgUseExternalEditor, $wgExternalDiffEngine, before presenting the corresponding options to the user. Comment 1 Dan Jacobson 2009-06-07 01:24:24 UTC (An administrator should probably reset any users' bad choces with maintenance/userOptions.php before locking the power to change them away from them.) Comment 2 Chad H. 2009-06-08 13:41:47 UTC Looks good. Can't commit from here, though. If no one else commits, I'll grab this tonight after work. Comment 3 Chad H. 2009-06-09 23:01:07 UTC Done in r51667