Last modified: 2009-06-09 20:56:42 UTC
A user uploaded an animated gif ~400k that has many frames to my wiki. Convert seemed to take forever to finish holding up fastcgi and causing it to stop responding (effectively being my site down) Do we actually need to scale/thumbnail animated gifs? wouldn't it be better to use convert blah.gif[0] by default on all gifs to only process the first frame ? the evil gif http://malus.exotica.org.uk/~buzz/animated.gif I;m marking this as major, as the defaults are not sensible enough to protect from this. The Bitmap.php code only processes the first frame if if( $srcWidth * $srcHeight > $wgMaxAnimatedGifArea ) { however this doesn't help for a gif with small dimensions but many frames.
Wikimedia wikis used to refuse to thumbnail GIFs at all (even non-animated ones, for some reason) owing to this, but they now do again, so I'm assuming (or at least hoping) they have some mechanism in place to prevent this.
It should use the first frame if ( $srcWidth * $srcHeight * $srcFrames > $wgMaxAnimatedGifArea ), but once the functionality to count frames is added, this would be resolved one way or the other. *** This bug has been marked as a duplicate of bug 16451 ***
