Last modified: 2010-07-04 17:19:33 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T21050, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 19050 - convertUserOptions.php unnecessarily copies empty fields
convertUserOptions.php unnecessarily copies empty fields
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Maintenance scripts (Other open bugs)
1.16.x
All All
: Normal trivial (vote)
: ---
Assigned To: Andrew Garrett
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2009-06-02 00:44 UTC by Dan Jacobson
Modified: 2010-07-04 17:19 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Dan Jacobson 2009-06-02 00:44:59 UTC 
After running convertUserOptions.php one finds these empty items are
unnecessarily copied into the user_properties table:
>SELECT COUNT(*),up_property FROM user_properties WHERE up_value ='' GROUP BY up_property;
COUNT(*)	up_property
19	ajaxsearch
3	date
16	nickname
1	quickbar
1	showjumplinks
1	showtoc
2	showtoolbar
126	skin
45	timecorrection
52	variant
Comment 1 Dan Jacobson 2009-06-07 01:11:56 UTC 
Also convertUserOptions.php should not create rows if that row would be the
same as its $wgDefaultUserOptions.
Comment 2 Andrew Garrett 2009-07-16 17:07:57 UTC 
(batch change)

Minor bugs that nevertheless need looking into
Comment 3 Andrew Garrett 2009-07-17 15:39:09 UTC 
Does this issue still occur? I've tightened this up quite a bit, I think.
Comment 4 Dan Jacobson 2009-07-17 20:38:56 UTC 
Somebody else please test, as I've already converted my users' options and have none left to test on.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links