Last modified: 2011-04-30 01:16:46 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T21047, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 19047 - wgGroupPermissions and deletedhistory
wgGroupPermissions and deletedhistory
Status: RESOLVED INVALID
Product: MediaWiki
Classification: Unclassified
Page protection (Other open bugs)
1.14.x
All All
: Normal major (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-06-02 00:12 UTC by jcn50
Modified: 2011-04-30 01:16 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description jcn50 2009-06-02 00:12:21 UTC
Hi~


When added to LocalSettings, this line doesn't work:
$wgGroupPermissions['*']['deletedhistory'] = false;
because the History tab is still shown for visitors...

From Manual page here:
http://www.mediawiki.org/wiki/Manual:User_rights
"allows viewing deleted revisions, but not restoring"
so when set to FALSE, History tab should disappear.


Thanks~
Comment 1 Chad H. 2009-06-02 00:41:15 UTC
Why would the history tab disappear? You should still be able to see all of the non-deleted revisions.

Unless I'm seriously missing something here, this is operating as intended. INVALID?
Comment 2 jcn50 2009-06-02 00:47:37 UTC
FALSE ("allows viewing deleted revisions, but not restoring") = "forbid viewing deleted revisions, and forbid restoring"

Am I wrong?...
What's the different between TRUE & FALSE then?.. The restore feature ONLY?..
Comment 3 Chad H. 2009-06-02 00:51:38 UTC
You understand the feature correctly. The misunderstanding is that that feature has nothing to do with displaying the history tab, as an article will have history that isn't deleted.

Removing 'need-review', as there is no patch to review.
Comment 4 jcn50 2009-06-02 00:56:02 UTC
I can see the deleted revisions... from the history tab!

So maybe it has only an effect on the restoring feature ??..
Comment 5 Chad H. 2009-06-02 01:04:27 UTC
Your original question: 

> When added to LocalSettings, this line doesn't work:
> $wgGroupPermissions['*']['deletedhistory'] = false;
> because the History tab is still shown for visitors...

What I said above applies: they will still be able to see the (non-deleted parts of) page history, so it's obvious that the history tab will still show. 

What you've said now: 

> I can see the deleted revisions... from the history tab!

Is a different thing entirely. I'm assuming you're logged in as a sysop (or some other group that has deletedhistory rights)?
Comment 6 jcn50 2009-06-02 01:10:55 UTC
Ok about the History Tab showing.

>> I can see the deleted revisions... from the history tab!

> Is a different thing entirely. I'm assuming you're logged in as a sysop (or
> some other group that has deletedhistory rights)?

No no, I confirm: I'm not logged when testing the feature...!
Comment 7 jcn50 2009-06-02 01:54:06 UTC
I tried the following:
$wgGroupPermissions['*']['deletedhistory'] = true;
I don't see any difference, so:
* either there is a mistatement in the Manual ;
or
* this feature is buggy~


As for hidding the History Tab, you're right: the additional extension "GroupPermissionsManager" is needed.
Comment 8 Chad H. 2009-06-02 01:57:08 UTC
If you haven't deleted any individual revisions, then the UI wouldn't look different, you're right. All revisions would show up in the history as normal.
Comment 9 Ryan Schmidt 2009-06-02 02:03:10 UTC
deleted revisions and old revisions are NOT the same thing.

When you click on the history tab, you are shown all of the old revisions of the page (aka versions of the page that have since been edited).

A deleted revision, on the other hand, is one of those revisions that have been removed from the public eye via the delete tab. As you probably know, the delete tab "removes" the page from the wiki, meaning that people without proper access cannot view the page.

The 'deletedhistory' permission controls the ability to actually view the history of those deleted revisions. By going to Special:Undelete (not the history tab), you can search for deleted pages and view the deleted history for that page if you have the right. If you don't have the right, you will be unable to do that.

This should probably be closed as INVALID
Comment 10 jcn50 2009-06-02 08:16:56 UTC
Ok, I understand now.
Bug report closed as INVALID.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links