Last modified: 2011-05-02 19:56:43 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T20962, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 18962 - Special ListFiles has the sorting arrow switched
Special ListFiles has the sorting arrow switched
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
unspecified
All All
: Normal minor (vote)
: ---
Assigned To: Trevor Parscal
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-05-27 21:11 UTC by Subfader
Modified: 2011-05-02 19:56 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Subfader 2009-05-27 21:11:48 UTC
http://commons.wikimedia.org/w/index.php?title=Special:ListFiles&sort=img_size&limit=50&desc=1

The arrow for sorting asc/desc should be the other way around.
Comment 1 Brion Vibber 2009-05-27 21:51:03 UTC
Indeed, the directions used are opposite that of in-wiki sortable table headers, which also match eg Finder's sorted file views. The small end of the arrow should match up with the low end (smaller numbers, earlier letters), while the big end of the arrow should match up with larger numbers/later letters.

Probably this needs to be fixed in the table pager class.
Comment 2 Brion Vibber 2009-07-20 03:56:20 UTC
Visual style fix -- putting this on Trevor's plate. :)
Comment 3 Subfader 2010-03-29 00:06:38 UTC
still
Comment 4 Subfader 2010-05-15 22:17:40 UTC
Solution: includes\Pager.php:
Just switch the images:

					if ( $this->mDefaultDirection ) {
						# Descending
						$image = 'Arr_u.png';
						$query['asc'] = '1';
						$query['desc'] = '';
						$alt = htmlspecialchars( wfMsg( 'descending_abbrev' ) );
					} else {
						# Ascending
						$image = 'Arr_d.png';
						$query['asc'] = '';
						$query['desc'] = '1';
						$alt = htmlspecialchars( wfMsg( 'ascending_abbrev' ) );
					}
Comment 5 Platonides 2010-05-15 22:23:14 UTC
I'm not sure it's wrong. If it's descending, it shows the ascending image (click her to show ascending), and viceversa.
Comment 7 Subfader 2010-05-16 00:04:20 UTC
Ok I see what you mean with the opposite behaviour to indicate what happens after the click. That's totally not user-firendly ("Don't make me think").

It looks wrong, not what you'd expect the arrow to be like. That's what counts imo.
Comment 8 DieBuche 2011-05-02 19:56:43 UTC
r87286

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links