Last modified: 2014-02-28 21:47:43 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T20906, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 18906 - Cortado doesn't handle incomplete packets correctly
Cortado doesn't handle incomplete packets correctly
Status: RESOLVED FIXED
Product: Cortado
Classification: Unclassified
JST (Other open bugs)
unspecified
All All
: Normal major (vote)
: ---
Assigned To: Nobody - You can work on this!
http://webcam.firestorm.cx/
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-05-25 12:28 UTC by Philip Heron
Modified: 2014-02-28 21:47 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Update jogg's handling of incomplete packets (980 bytes, patch)
2009-05-25 12:28 UTC, Philip Heron
Details

Description Philip Heron 2009-05-25 12:28:52 UTC
Created attachment 6150 [details]
Update jogg's handling of incomplete packets

This patch updates the pagein function to match the current libogg implemnation. This fixes a bug where Cortado would die when a Theora stream begins with an incomplete packet, and tries to process it as a header.

I have been testing this patch on my website, and so far so good.
Comment 1 Siebrand Mazeland 2009-06-01 16:55:28 UTC
+need-review
Comment 2 Sumana Harihareswara 2012-09-05 17:59:55 UTC
Philip, thanks for the patch, and my apologies that it has taken so long to review!

Is it still necessary?

If so, it would be great if you could submit it directly into our source control system: https://www.mediawiki.org/wiki/Git/Tutorial
Comment 3 Andre Klapper 2012-12-17 12:14:18 UTC
TimedMediaHandler was deployed at the beginning of November 2012, see
https://www.mediawiki.org/wiki/TimedMediaHandler and http://blog.wikimedia.org/2012/11/08/introducing-wikipedias-new-html5-video-player/ for more information.
It is based on HTML5 and supports closed captions, timed text, WebM, etc.

This bug report was reported about "Cortado". With TimedMediaHandler being in place, Cortado is now ONLY used as a fallback for web browsers that do not support any of the video codecs we offer but have Java installed. This currently is Apple Safari without XiphQt installed, or Microsoft Internet Explorer with Java applet installed. 

Please add a comment here in case that you still face the problem described (now with Cortado inside of TimedMediaHandler) if using one of the browsers mentioned above. In that case, this report should be moved to product="MediaWiki extensions" and component="TimedMediaHandler" in this bug tracker.

Issues that also happen with Cortado without TimedMediaHandler should be reported to https://trac.xiph.org/ instead.
Comment 4 Andre Klapper 2014-02-28 21:47:43 UTC
Fixed four years ago in upstream: https://trac.xiph.org/ticket/1565

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links