Last modified: 2009-05-28 03:48:21 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T20853, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 18853 - Incorrect escaping kills Javascript in Swedish localization
Incorrect escaping kills Javascript in Swedish localization
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
SemanticForms (Other open bugs)
unspecified
All All
: Normal major (vote)
: ---
Assigned To: Yaron Koren
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-05-20 12:20 UTC by Lance Skoglund
Modified: 2009-05-28 03:48 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Lance Skoglund 2009-05-20 12:20:50 UTC
The quote around http kills the javascript when you try to add another template. The function validate_field_type fails.

Change the row below in SF_Messages.php

'sf_bad_url_error' => 'måste ha korrekt URL-format, inkluderande "http"'

to 

'sf_bad_url_error' => 'måste ha korrekt URL-format, inkluderande http'
Comment 1 Niklas Laxström 2009-05-20 12:59:22 UTC
Problem is in escaping, not in the localisation, of course.
Comment 2 Brion Vibber 2009-05-26 20:54:15 UTC
Looks like SFFormUtils::validationJavascript() needs to make some calls to Xml::escapeJsString()... Likely other functions generating JS with localized text are similarly broken.
Comment 3 Yaron Koren 2009-05-28 03:48:21 UTC
Xml::escapeJsString() calls added in Semantic Forms 1.7.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links