Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T20842, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 18842 - Comments hidden with RevDeleted silently suppressed, not marked "(Comment removed)" (patch)

Summary:	Comments hidden with RevDeleted silently suppressed, not marked "(Comment rem...

Status: RESOLVED FIXED Product: MediaWiki Classification: Unclassified Component: Revision deletion (Other open bugs) Version: 1.15.x Hardware: All All Importance: Normal normal (vote) Target Milestone: --- Assigned To: Nobody - You can work on this! URL: Whiteboard: Keywords: patch, patch-need-review Depends on: Blocks: revdel   Show dependency tree / graph		Reported: 2009-05-18 21:42 UTC by Happy-melon Modified: 2009-05-26 12:41 UTC (History) CC List: 1 user (show) aschulz4587 See Also: Web browser: --- Mobile Platform: --- Assignee Huggle Beta Tester: ---

Attachments against r50747, fixes bug in Linker::revComment() (1.39 KB, patch) 2009-05-18 21:42 UTC, Happy-melon Details Add an attachment (proposed patch, testcase, etc.)

Description Happy-melon 2009-05-18 21:42:25 UTC Created attachment 6133 [details] against r50747, fixes bug in Linker::revComment() Linker::revComment() is buggy: if the comment has been hidden, it is treated as a blank comment rather than displaying the correct "(Comment removed)" message. Plus the code was messy :D Comment 1 Happy-melon 2009-05-18 22:21:34 UTC This was (I think) handled in r50757. I still think my code is cleaner :D Comment 2 Aaron Schulz 2009-05-18 22:22:56 UTC Yes, done in r50757