Last modified: 2014-04-23 00:32:03 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T20831, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 18831 - Wikibugs does not always report the real name instead of e-mail prefix when reporting on IRC
Wikibugs does not always report the real name instead of e-mail prefix when r...
Status: RESOLVED FIXED
Product: Wikimedia
Classification: Unclassified
wikibugs IRC bot (Other open bugs)
unspecified
All All
: Low enhancement with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
:
: 23974 34506 42504 (view as bug list)
Depends on: 59076
Blocks:
  Show dependency treegraph
 
Reported: 2009-05-18 05:35 UTC by MZMcBride
Modified: 2014-04-23 00:32 UTC (History)
10 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Modify wikibugs to use "real name" instead of e-mail prefix when possible (2.13 KB, patch)
2011-06-06 05:29 UTC, MZMcBride
Details
Untested patch to fix the "real name" issue without using so much regex hackery (1.38 KB, patch)
2011-07-20 01:26 UTC, MZMcBride
Details

Description MZMcBride 2009-05-18 05:35:37 UTC
If possible, wikibugs should use the real name field instead of the first part of the e-mail address when reporting bug changes. For example, this:

<wikibugs> (mod) Can't link to [[{{FULLPAGENAME}}]] any more - https://bugzilla.wikimedia.org/show_bug.cgi?id=18828  +comment (herd)

would become this:

<wikibugs> (mod) Can't link to [[{{FULLPAGENAME}}]] any more - https://bugzilla.wikimedia.org/show_bug.cgi?id=18828  +comment (Splarka)

Seems much more useful and identifiable to use real names over e-mail address parts.
Comment 1 Brion Vibber 2009-05-18 17:58:51 UTC
Andrew, wanna take a peek at this some time? :D
Comment 2 Andrew Garrett 2009-07-03 13:20:14 UTC
Annoyingly, bugzilla doesn't provide this information in a way that's machine-readable without horrible and fragile regexes.
Comment 3 Andrew Garrett 2009-07-16 17:04:31 UTC
(Batch change)

These are low-priority miniprojects that I can mop up at some point when I'm doing general code work as opposed to working on a specific projects.
Comment 4 Thor Malmjursson 2010-04-14 12:31:20 UTC
I have posted a similar issue, bug 23159, which if resolved, may very well clear this one up.  If someone wants to take a look at that, maybe you can hit 2 bugs in one go.  Since the bot uses email prefixes, if we change the login to work as Wiki* would, i.e, assigning a real name or username instead of email as your login, the bot would pick that up instead I believe.
Comment 5 Sam Reed (reedy) 2010-06-15 11:38:32 UTC
*** Bug 23974 has been marked as a duplicate of this bug. ***
Comment 6 Hydriz Scholz 2011-06-04 14:55:30 UTC
Resolving this bug *might* benefit me the most as I have "admin" as my email prefix. I would therefore be listed as "admin" in #mediawiki, which makes me a little weird.
Comment 7 MZMcBride 2011-06-06 05:29:03 UTC
Created attachment 8617 [details]
Modify wikibugs to use "real name" instead of e-mail prefix when possible

There's apparently a "X-Bugzilla-Who" header sent with every e-mail, so grabbing just the e-mail address is fairly reliable now. Getting the real name still requires regex hackery, but seems fairly straightforward.
Comment 8 Mark A. Hershberger 2011-06-08 04:10:41 UTC
r89717
Comment 9 MZMcBride 2011-07-20 01:26:03 UTC
Created attachment 8805 [details]
Untested patch to fix the "real name" issue without using so much regex hackery

Re-opening this. The regex currently in use is causing strangeness such as "Brion Vibber <brio". This is broken.

I don't see any reason to try to do fancy lookahead magic here any longer. It was necessary when X-Bugzilla-Who wasn't used/available, but with that, it's much more reliable to try to grab only the real name _or_ use the first part of the e-mail address.

Untested patch against r92606 attached.
Comment 10 p858snake 2012-02-19 00:54:32 UTC
*** Bug 34506 has been marked as a duplicate of this bug. ***
Comment 11 Antoine "hashar" Musso (WMF) 2012-03-05 10:41:26 UTC
Fixed with r113013. Pending review / deployment.
Comment 12 Daniel Zahn 2012-03-19 01:18:48 UTC
deployed / updated on mchenry from latest svn, killed and restarted
Comment 13 Antoine "hashar" Musso (WMF) 2012-03-19 09:05:21 UTC
Thanks Daniel!
Comment 14 Alex Monk 2012-03-19 23:25:24 UTC
This is still happening:

<wikibugs> (NEW) Wikipedia and other site logos pixelated, blurry on high-resolution screens - https://bugzilla.wikimedia.org/35337 normal; Wikimedia: Site logos; (brion)
<wikibugs> (mod) High-density display issues tracking bug (Android hdpi & xhdpi, iPhone Retina display) - https://bugzilla.wikimedia.org/32101  (Brion Vibber)
Comment 15 Andre Klapper 2012-11-13 14:36:24 UTC
(In reply to comment #14)
> This is still happening:

Adjusting summary.
Comment 16 Alex Monk 2012-11-28 18:44:46 UTC
*** Bug 42504 has been marked as a duplicate of this bug. ***
Comment 17 Bartosz Dziewoński 2012-12-01 14:30:53 UTC
This is impossible to do without rewriting wikibugs to use a sane API instead of parsing bugmail, as it doesn't include the reporter's full name when a new bug is submitted. (Alternatively, we could hack bugmail to include it.)
Comment 18 Liangent 2013-04-12 11:54:15 UTC
(In reply to comment #17)
> This is impossible to do without rewriting wikibugs to use a sane API instead
> of parsing bugmail, as it doesn't include the reporter's full name when a new
> bug is submitted. (Alternatively, we could hack bugmail to include it.)

It fails not only for new bug messages...

<wikibugs> (mod) zh: Missing whitespace between strings for notification of a page change in my watchlist - https://bugzilla.wikimedia.org/47160  +comment (Nemo)
<wikibugs> (mod) zh: Missing whitespace between strings for notification of a page change in my watchlist - https://bugzilla.wikimedia.org/47160  +comment (federicoleva)
Comment 19 MZMcBride 2013-12-28 17:02:49 UTC
(In reply to comment #17)
> This is impossible to do without rewriting wikibugs to use a sane API instead
> of parsing bugmail, as it doesn't include the reporter's full name when a new
> bug is submitted. (Alternatively, we could hack bugmail to include it.)

This is bug 40970, by the way.
Comment 20 Merlijn van Deen (test) 2014-04-22 20:16:04 UTC
Fixed in pywikibugs.
Comment 21 MZMcBride 2014-04-23 00:32:03 UTC
\o/

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links