Last modified: 2009-07-15 22:51:45 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T20821, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 18821 - Revision::fetchAllRevisions has LIMIT=1, thus not returning all revisions
Revision::fetchAllRevisions has LIMIT=1, thus not returning all revisions
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
History/Diffs (Other open bugs)
1.16.x
All All
: Normal minor (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-05-17 09:00 UTC by Charlie Chernohorsky
Modified: 2009-07-15 22:51 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Charlie Chernohorsky 2009-05-17 09:00:44 UTC
Revision::fetchAllRevisions (http://svn.wikimedia.org/doc/Revision_8php-source.html#l00205) does its work using Revision::fetchFromConds (http://svn.wikimedia.org/doc/Revision_8php-source.html#l00243), which has a fixed LIMIT=1 (http://svn.wikimedia.org/doc/Revision_8php-source.html#l00253), thus not returning all revisions, but only one of them.
Comment 1 Brion Vibber 2009-05-18 18:13:08 UTC
The LIMIT=1 was added in r9211 in 2005...

Revision::fetchAllRevisions() appears to be unused, and well it should be unused as it would work very poorly on large pages. :)

Probably best fix is to kill the bad function.
Comment 2 Chad H. 2009-07-15 22:51:45 UTC
Nuked it in r53339

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links