Last modified: 2011-07-26 08:56:18 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T20809, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 18809 - Extension:NewUserMessage using template substitution
Extension:NewUserMessage using template substitution
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
NewUserMessage (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Siebrand Mazeland
: patch, patch-need-review
Depends on:
Blocks: 19041
  Show dependency treegraph
 
Reported: 2009-05-15 20:36 UTC by Strainu
Modified: 2011-07-26 08:56 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Diffs of all the files in the extension (2.10 KB, patch)
2009-05-15 20:36 UTC, Strainu
Details
Diffs of all the files in the extension (2.10 KB, patch)
2009-05-15 20:40 UTC, Strainu
Details
New version of the diff (794 bytes, patch)
2009-05-17 21:12 UTC, Strainu
Details

Description Strainu 2009-05-15 20:36:50 UTC
Created attachment 6124 [details]
Diffs of all the files in the extension

Hi,

I've changed this extension a bit so it receives another parameter telling it if it should include or substitute the "Welcome" template. It seems substitution is "a la mode", even if I find its advantages to be limited. While I was at it, I've also included a Romanian translation.

Hope this code will make it in the SVN.

Regards,
  [[:ro:Utilizator:Strainu]]

P.S. I couldn't find NewUserMessage as a component, so I chose Newuserlog, cause it was marked as "related". Hope the fact theat Newuserlog is deprecated doesn't mean the enhancement is rejected.
Comment 1 Strainu 2009-05-15 20:40:01 UTC
Created attachment 6125 [details]
Diffs of all the files in the extension
Comment 2 Siebrand Mazeland 2009-05-17 20:46:16 UTC
Two comments:
* please do the localisation at translatewiki.net; that's a lot easier and streamlined (and you can as well localise a lot more into Romanian)
* make the new settings configurable in a message; that will allow a user community (and not a server administrator) to decide if a template will be substituted or not.
Comment 3 Strainu 2009-05-17 21:12:03 UTC
Created attachment 6127 [details]
New version of the diff

The substitution is now made if there is any text in MediWiki:Newusermessage-substitute
Comment 4 Siebrand Mazeland 2009-06-01 17:41:04 UTC
Applied in r51297 with changes. Thanks.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links