Last modified: 2009-07-25 20:11:19 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T20799, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 18799 - use wgContLang to ignore returnto=Special:UserLogout by login
use wgContLang to ignore returnto=Special:UserLogout by login
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
User login and signup (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
http://translatewiki.net/w/i.php?titl...
: easy
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-05-14 19:43 UTC by Umherirrender
Modified: 2009-07-25 20:11 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Umherirrender 2009-05-14 19:43:51 UTC
SpecialUserlogin.php using wgLang to ignore a returnto=Special:Userlogout, this fails for user with an other language than the content.

I think it is better to use wgContLang for the code in SpecialUserlogin.php: 
# When switching accounts, it sucks to get automatically logged out
if( $this->mReturnTo == $wgLang->specialPage( 'Userlogout' ) )
{
 $this->mReturnTo = '';
}

You can test it by setlang!=en on translatewiki an than try to login, when there is a returnto=Special:UserLogout in the url
Comment 1 Brion Vibber 2009-05-14 23:11:57 UTC
This should check with SpecialPage::resolveAlias() or such rather, so all aliases are caught.
Comment 2 Umherirrender 2009-05-25 19:33:15 UTC
Please also normalize the parameter 'returnto'.
Comment 3 Alexandre Emsenhuber [IAlex] 2009-07-25 20:11:19 UTC
fixed in r53763.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links