Last modified: 2012-09-27 01:14:30 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T20779, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 18779 - Modern Skin should have print-specific CSS
Modern Skin should have print-specific CSS
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Interface (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-05-13 01:34 UTC by Derk-Jan Hartman
Modified: 2012-09-27 01:14 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
include commonPrint.css (562 bytes, patch)
2009-05-13 01:34 UTC, Derk-Jan Hartman
Details
Print with Monobook skin (329.92 KB, application/pdf)
2009-05-13 12:25 UTC, Derk-Jan Hartman
Details
print with Modern skin (326.70 KB, application/pdf)
2009-05-13 12:26 UTC, Derk-Jan Hartman
Details
print with patched Modern skin (324.73 KB, application/pdf)
2009-05-13 12:26 UTC, Derk-Jan Hartman
Details

Description Derk-Jan Hartman 2009-05-13 01:34:45 UTC
Created attachment 6110 [details]
include commonPrint.css

The modern skin is severely broken when printing, because it doesn't include commonPrint.css (which sets styling for thumbs etc). Although some of the defines of commonPrint.css are totally useless, several others are highly critical. Since it seems that the modern/print.css was never really finished, I think that we should include commonPrint.css instead, at the very least until the modern skin is finished.
Comment 1 Andrew Garrett 2009-05-13 01:38:04 UTC
Updating bug summary.
Comment 2 River Tarnell 2009-05-13 07:16:12 UTC
i can't reproduce any severe brokenness.  please describe the problem in more detail, and if possible, provide an example of a page that demonstrates it.
Comment 3 Derk-Jan Hartman 2009-05-13 12:25:14 UTC
I'll attach three "print to pdf" files (Of the OS X print core, not "the mediawiki PDF version"). All the same article, with monobook skin, modern skin and a "patched" modern skin.

Observe the differences in rendering of thumbs, links, TOC and the appending of href element to external links. Mostly dealt with by commonPrint.css  I have no problem with Modern providing an additional print skin, but I don't see why it should ignore the "shared" one that sets some very reasonable options. There are several elements in commonPrint.css that are not used in modern (#content), but these can be fixed either later, or implemented in modern/print.css at a later time.


Please ignore the articles headers (metadata extension in place there), and underlines (which i add myself to redirect links).
Comment 4 Derk-Jan Hartman 2009-05-13 12:25:58 UTC
Created attachment 6112 [details]
Print with Monobook skin
Comment 5 Derk-Jan Hartman 2009-05-13 12:26:26 UTC
Created attachment 6113 [details]
print with Modern skin
Comment 6 Derk-Jan Hartman 2009-05-13 12:26:50 UTC
Created attachment 6114 [details]
print with patched Modern skin
Comment 7 Derk-Jan Hartman 2010-04-18 15:32:01 UTC
This problem with thumbnails in printed pages of the modern skin still exist. Either my patch needs applying, or the rules for thumb styling need to be copied from commonPrint.css to modern/print.css
Comment 8 Sam Reed (reedy) 2011-02-11 01:38:04 UTC
Why don't you apply your patches? ;)
Comment 9 Mark A. Hershberger 2011-04-06 23:49:53 UTC
patch is super-obsolete (Resource Loader FTW!) but the problem remains.
Comment 10 Bugmeister Bot 2011-08-19 19:12:40 UTC
Unassigning default assignments. http://article.gmane.org/gmane.science.linguistics.wikipedia.technical/54734
Comment 11 Sam Reed (reedy) 2011-11-19 19:35:10 UTC
Comment on attachment 6110 [details]
include commonPrint.css

Obsolete, already applied (or otherwise changed as such)
Comment 12 Derk-Jan Hartman 2011-12-04 13:15:37 UTC
This issue has been solved now.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links