Last modified: 2009-08-07 15:44:38 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T20708, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 18708 - Move .plainlinks declaration to common stylesheets
Move .plainlinks declaration to common stylesheets
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Parser (Other open bugs)
1.15.x
All All
: Normal enhancement with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch, patch-need-review
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-05-07 19:39 UTC by Happy-melon
Modified: 2009-08-07 15:44 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Moves .plainlinks to common stylesheets (2.32 KB, patch)
2009-05-08 17:04 UTC, Happy-melon
Details

Description Happy-melon 2009-05-07 19:39:34 UTC
Icons are added to links in skins other than monobook (modern and simple).  Ergo, plainlinks needs also to be availalbe in those skins.  Ergo, it should be moved from monobook/main.css to common/shared.css.
Comment 1 Derk-Jan Hartman 2009-05-08 16:03:18 UTC
proposals would be:

.plainlinks a {
	background: none !important;
	padding: 0 !important;
}

This would however require that the skins set their specificity different. That would need to be tested at least.
Alternative is:

#content .plainlinks a,
#mw_content .plainlinks a {
	background: none !important;
	padding: 0 !important;
}

The !important is needed because the assigning of icons actually happens at a LATER time (the skins), and would thus override this "global" class.
Comment 2 Happy-melon 2009-05-08 17:04:43 UTC
Created attachment 6095 [details]
Moves .plainlinks to common stylesheets

The !important declarations are *not* required, only that the override has a higher specificity than the original asignations.  Simply adding "div#ID" will work.  

Patch, tested on FF3; no reason I'm aware of why it shouldn't work in anything capable of adding the icons in the first place.  The patch *itself* might be dodgy; I've got a huge amount of stuff going on on my svn checkout ATM, so it was cut-and-pasted together from a couple of different diffs, with irrelevant bits cut out.  It should apply, though.  The *content* of the changes has been tested.
Comment 3 Derk-Jan Hartman 2009-05-11 10:02:43 UTC
I just realized that both the old and the patched way don't define plainlinks for print.. 
Comment 4 Siebrand Mazeland 2009-05-17 14:49:25 UTC
Remove 'easy' per comment 3.
Comment 5 Happy-melon 2009-05-17 15:00:19 UTC
But that's a separate issue; as Derk notes, both the old and new code has the problem, so it's not a regression.  It should definitely be *fixed* (by adding the same declaration to CommonPrint.css) but that doesn't affect the ease-of-resolution of *this* bug.
Comment 6 Chad H. 2009-07-15 23:36:37 UTC
Done in r53344.
Comment 7 Derk-Jan Hartman 2009-08-07 15:44:38 UTC
This revision should probably be added to acaifix and wmf-deployment

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links