Last modified: 2012-10-16 15:39:31 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T20702, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 18702 - Wrong colors
Wrong colors
Status: RESOLVED WORKSFORME
Product: Cortado
Classification: Unclassified
jheora (Other open bugs)
unspecified
All All
: Normal major (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-05-07 09:43 UTC by Damien Guillaume
Modified: 2012-10-16 15:39 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Damien Guillaume 2009-05-07 09:43:41 UTC
Colors for an ogg theora file are wrong. Red shows up as a pale orange.

I think this bug is caused by the conversion from YUV to RBG and I suggest the following patch in YUVBuffer.java :

replace

	GFactor = UFactor * CR_DIFF_FAC + VFactor * CB_DIFF_FAC - (VAL_RANGE<<SHIFT);
	UFactor = UFactor * CR_FAC + (VAL_RANGE<<SHIFT);
	VFactor = VFactor * CB_FAC + (VAL_RANGE<<SHIFT);

by

	GFactor = UFactor * CB_DIFF_FAC + VFactor * CR_DIFF_FAC - (VAL_RANGE<<SHIFT);
	UFactor = UFactor * CB_FAC + (VAL_RANGE<<SHIFT);
	VFactor = VFactor * CR_FAC + (VAL_RANGE<<SHIFT);
Comment 1 Andre Klapper 2012-10-16 15:39:31 UTC
Code does not exist anymore in upstream http://git.xiph.org/?p=cortado.git;a=blob;f=src/com/fluendo/jheora/YUVBuffer.java;h=9e300650447bb56a88cd223c7b617491e47a7310;hb=HEAD

Closing as obsolete.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links