Last modified: 2013-08-29 19:38:53 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T20672, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 18672 - Change Tags structure to use numeric IDs instead of text
Change Tags structure to use numeric IDs instead of text
Status: NEW
Product: MediaWiki
Classification: Unclassified
Change tagging (Other open bugs)
unspecified
All All
: Low enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-05-04 02:09 UTC by MZMcBride
Modified: 2013-08-29 19:38 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description MZMcBride 2009-05-04 02:09:16 UTC
Currently the Tags core feature is using text names to refer to individual tags. Referring to the tags using an ID number seems like a much better solution overall.

It avoids typos or poor naming choices from being stored in the database forever (and in the MediaWiki: messages). It also ensures cleaner database results, allows for easier joining with other tables in the future (for outside extensions), and avoids the general nastiness of allowing (apparently) any character in the tag name, including question marks, quotation marks, ampersands, etc.

Awaiting vociferous opposition and a rapid close.
Comment 1 Andrew Garrett 2009-07-16 16:47:51 UTC
Marking this bug as Lowest priority.

I've done this in a batch to (usually enhancement request) bugs where:
* It is not clear that this bug should be fixed.
* It is not clear how to fix this bug.
* There are difficulties or complications in fixing this bug, which are not justified by the importance of the bug.
* This is an extremely minor bug that could not be fixed in a few lines of code.

If you're interested in having one of these bugs fixed, your best bet is to write the patch yourself.
Comment 2 db [inactive,noenotif] 2013-03-21 20:42:07 UTC
varchar is more flexibel and you have not to look up the long name (performance).
The ContentHandler was implemented with integers, but than moved to varchar for the same reasons.
Comment 3 Andre Klapper 2013-07-26 15:27:53 UTC
Helder: Comment 1 requires answers before raising priority.
Comment 4 Helder 2013-07-26 18:17:53 UTC
Now that bug 25824 was fixed, if a filter is created to tag some edits and the author choose a very unappropriated tag name, it will show up in the diffs of any edits detected by such a filter
http://test.wikipedia.org/w/index.php?title=Bug18672&diff=176578

When this is problematic, sysops still have no way to fix remove a tag from a revision:
* False positives can't be marked/reverted (bug 28213), and as such the tags can't be hidden in these cases
* Poorly named tags can't be renamed (this bug)

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links