Last modified: 2014-11-17 10:35:51 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T20655, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 18655 - Abuse filter log: 'details' and 'examine' redundant
Abuse filter log: 'details' and 'examine' redundant
Status: NEW
Product: MediaWiki extensions
Classification: Unclassified
AbuseFilter (Other open bugs)
unspecified
All All
: Lowest minor with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-05-02 19:50 UTC by Gurch
Modified: 2014-11-17 10:35 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Gurch 2009-05-02 19:50:29 UTC
As far as I can see, the only difference between the "details" and "examine" links in the abuse filter log are that the "details" link shows the log entry and a diff of the change, whereas "examine" does not. Both have a listing of the variables for that action. Are separate links really necessary?
Comment 1 Andrew Garrett 2009-07-03 13:02:39 UTC
'examine' also includes an interface for testing a filter against a change.
Comment 2 Gurch 2009-07-03 13:32:13 UTC
(In reply to comment #1)
> 'examine' also includes an interface for testing a filter against a change.

True, but that interface isn't shown when following the 'examine' link on a log entry, only when going to [[Special:AbuseFilter/examine]].

I'm not suggesting getting rid of that interface entirely, just not showing the 'examine' link on log entries.
Comment 3 Mike.lifeguard 2009-07-03 23:14:34 UTC
(In reply to comment #1)
> 'examine' also includes an interface for testing a filter against a change.
> 

Then why have /details if it's the same only minus a feature?
Comment 4 Gurch 2009-07-04 21:33:47 UTC
(In reply to comment #3)
> Then why have /details if it's the same only minus a feature?

"Details" shows the log entry and a diff of the change, as well as the listing of variables for that action. "examine" only has the list of variables (and the interface for testing a filter, when accessed through [[Special:AbuseFilter/examine]].

Both are useful. However *in the log* the "examine" link doesn't add anything that the "details" one doesn't. This bug is only about dropping one of those links to aid usability. Dropping the "details" one would be the wrong thing to do as the diff is a pretty essential piece of information, so the "examine" one should be dropped.
Comment 5 Andrew Garrett 2009-07-16 16:47:51 UTC
Marking this bug as Lowest priority.

I've done this in a batch to (usually enhancement request) bugs where:
* It is not clear that this bug should be fixed.
* It is not clear how to fix this bug.
* There are difficulties or complications in fixing this bug, which are not justified by the importance of the bug.
* This is an extremely minor bug that could not be fixed in a few lines of code.

If you're interested in having one of these bugs fixed, your best bet is to write the patch yourself.
Comment 6 Kunal Mehta (Legoktm) 2012-12-14 14:51:33 UTC
Extremely old, but gerrit change I0985352d.
Comment 7 Gerrit Notification Bot 2013-04-17 12:01:35 UTC
https://gerrit.wikimedia.org/r/38716 (Gerrit Change I0985352d4e9e5d076df42d16d9a291d637715c4e) | change ABANDONED [by Legoktm]

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links