Last modified: 2014-02-12 23:37:56 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T20641, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 18641 - Allow notes on public filters to be edited by anyone.
Allow notes on public filters to be edited by anyone.
Status: NEW
Product: MediaWiki extensions
Classification: Unclassified
AbuseFilter (Other open bugs)
unspecified
All All
: Lowest enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-05-01 11:21 UTC by Gurch
Modified: 2014-02-12 23:37 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Gurch 2009-05-01 11:21:36 UTC
Currently the notes on a filter can only be edited by those able to edit the filter itself. For private filters this is fine, however it should be possible for anyone who can view a filter to comment on it. This requires either creation of a new user right for notes editing in the extension (which is then assigned to all users) or changing the "view" right to also allow editing of notes.
Comment 1 Andrew Garrett 2009-05-01 13:40:58 UTC
Not sure whether we actually want this or not.
Comment 2 Gurch 2009-05-01 15:39:44 UTC
Well, at the moment discussion of filters is split between the filter notes and wiki pages that anyone can edit. This is confusing and hard to follow. 
Comment 3 Andrew Garrett 2009-05-01 15:42:59 UTC
Originally, I envisiaged the notes section as a section for people to write miscellaneous comments on how the filters actually worked, what to watch out for, and so on. It is appropriate that actual discussion takes place on wiki pages, rather than in a random textbox.

The notes field is presently also used for change control – it would perhaps be prudent to add a 'Change summary' field to the edit window for filters, allowing that change control to be broken out of the more generic field, and displayed on the history page.

This would require a schema change.
Comment 4 Happy-melon 2009-05-01 23:12:15 UTC
Good thing it hasn't got 300 million rows in it then :D  You're definitely right that the notes field is being misused (not *ab*used, because there's not really much alternative) for a purpose it's not designed (or equipped) for.  Once that is fixed, this bug becomes invalid.
Comment 5 Andrew Garrett 2009-07-16 16:47:50 UTC
Marking this bug as Lowest priority.

I've done this in a batch to (usually enhancement request) bugs where:
* It is not clear that this bug should be fixed.
* It is not clear how to fix this bug.
* There are difficulties or complications in fixing this bug, which are not justified by the importance of the bug.
* This is an extremely minor bug that could not be fixed in a few lines of code.

If you're interested in having one of these bugs fixed, your best bet is to write the patch yourself.
Comment 6 Phuntsok Kongtsa 2011-08-05 01:59:55 UTC
I don't think that would be a good idea.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links