Last modified: 2009-05-06 11:11:50 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T20593, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 18593 - Unify svn-revision references in Special:Version
Unify svn-revision references in Special:Version
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Special pages (Other open bugs)
1.15.x
All All
: Normal enhancement with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
http://translatewiki.net/wiki/Special...
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-04-26 10:29 UTC by Purodha Blissenbach
Modified: 2009-05-06 11:11 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Purodha Blissenbach 2009-04-26 10:29:07 UTC
Currently, there are two kinds of references to
revisions in the subversion repository in Special:Version
1) with a link as (r98765) in the "MediaWiki" entry.
2) in extension entries like (Revision r01234) without a link.

I suggest to unify them to both include links, and to use
the same message format from the MediaWiki: name space.

See also bug 18592.
Comment 1 Shinjiman 2009-04-27 13:00:52 UTC
Applied on r49948.
Comment 2 Shinjiman 2009-04-27 13:17:15 UTC
Partly reverted the external link on the revision number in r49950.
The viewvc link can be browsed by clicking the link on the 
MediaWiki website's extension description page.
Comment 3 Brion Vibber 2009-04-27 17:58:05 UTC
This was partially reverted in r49950 apparently on the basis that it looks funny. :)

More seriously, it has some real problems:
* Hardcoded Wikimedia SVN URL means that extensions checked out from a third-party SVN will be totally wrong
* Hardcoded trunk path means that extensions checked out from branch will link to the totally wrong place
* Hardcoded path points just to 'extensions' and fails to specify the particular directory

You should be able to extract the actual source path out of the .svn files just like the version, in which case we can identify whether it's our own SVN and we can stick a pretty viewvc link on it -- with the correct path.
Comment 4 Shinjiman 2009-04-28 05:24:27 UTC
Hopefully whis was fixed on r49995.

* The link will follows which type of the script is downloaded, either trunk, branches and tags.
* The link on the extension field is only available if it is obtained from the WMF server, other third-party extension links will be disabled and only showing the revision number.
* The link will follows the path with which extensions is installed. For example CheckUser extension will go to the CheckUser extension, etc.
Comment 5 Purodha Blissenbach 2009-05-06 11:11:50 UTC
Thank you - good work.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links