Last modified: 2009-04-24 09:35:39 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T20553, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 18553 - GeSHI highlighting is broken for bashwhen an apostrophe/single quote is encountered inside a comment
GeSHI highlighting is broken for bashwhen an apostrophe/single quote is encou...
Status: RESOLVED DUPLICATE of bug 10967
Product: MediaWiki extensions
Classification: Unclassified
SyntaxHighlight (GeSHi) (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-04-22 05:49 UTC by fow
Modified: 2009-04-24 09:35 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description fow 2009-04-22 05:49:36 UTC
When an apostrophe or single quote is inside a quote, it is highlighted as if it's part of a command, i.e. it turns red until another single quote is found. Here's a simple example:

<source lang="bash">
# This is some text
# This is some more text
# It's a wonderful life
# This is more text that shouldn't be red

echo this is a command
</source>

An example of when this occurs in practice is [http://en.wikipedia.org/wiki/Wikipedia:Text_editor_support#Using_vim_or_another_console_editor here]. It is fixed upstream as evidenced by the demonstration box on [http://qbnz.com/highlighter/ the front GeSHI page].
Comment 1 Splarka 2009-04-22 05:58:32 UTC
Similar for javascript, most probably due to crappy regex. 
<source lang="javascript">var foo = /\'/;var bar = "wat";</source>

This isn't really the fault of the MediaWiki extension but the GeSHI backend. Suggest dupe to bug 10967 (same as bug 15175 was) if the bug is fixed in newer versions.
Comment 2 Niklas Laxström 2009-04-24 09:35:39 UTC
Confirmed that these are fixed in new versions. Duping.

*** This bug has been marked as a duplicate of bug 10967 ***

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links