Last modified: 2009-04-18 21:20:13 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T20507, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 18507 - OpenID Extension shouldn't set X-XRDS-Location header with header()
OpenID Extension shouldn't set X-XRDS-Location header with header()
Status: RESOLVED INVALID
Product: MediaWiki extensions
Classification: Unclassified
OpenID (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
http://mediawiki.org/wiki/Extension:O...
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2009-04-18 21:19 UTC by Charles Melbye
Modified: 2009-04-18 21:20 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Line that needs to be removed (834 bytes, patch)
2009-04-18 21:19 UTC, Charles Melbye 		Details
Add an attachment (proposed patch, testcase, etc.)

Description Charles Melbye 2009-04-18 21:19:11 UTC 
Created attachment 6038 [details]
Line that needs to be removed

The OpenID Extension is currently setting the X-XRDS-Location header with PHP's header() function. Apache's mod_fcgid doesn't like this, and it calls it a "malformed header".

Judging by a conversation on LiveJournal about this (http://www.livejournal.com/go.bml?journal=lj_dev&itemid=735100&dir=next), the header should not be set like this. Rather, it should be set in a <meta> HTML tag, which is what the extension is already doing.

The patch I've attached shows which line I'm talking about that needs to be removed.
Comment 1 Charles Melbye 2009-04-18 21:20:13 UTC 
Sorry, didn't realize this was already fixed.

Closing...
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links