Last modified: 2010-05-15 15:32:58 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 1849 - change behavior of Special:Unusedimages for the commons
change behavior of Special:Unusedimages for the commons
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Special pages (Other open bugs)
1.4.x
All All
: Normal enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2005-04-08 15:37 UTC by Daniel Kinzler
Modified: 2010-05-15 15:32 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
patched version of SpecialUnusedimages.php; Only getSQL is changed. (2.19 KB, text/plain)
2005-04-08 15:40 UTC, Daniel Kinzler
Details
real patch created using cvs diff -u SpecialUnusedimages.php (1.51 KB, patch)
2005-04-10 20:43 UTC, Daniel Kinzler
Details

Description Daniel Kinzler 2005-04-08 15:37:04 UTC
This patch causes Special:Unusedimages not to list images that have been put
into a category. This is usefull for the commons, where images don't have to be
on a article page, it's enough if they are categorized. For that reason, the
current behavior of Unusedimages is useless on the commons - it lists a lot of
images that are categorized and therefore do not require attention.

The patched Unusedimages still lists images that are categorized indirectly
through a template (this is due to the way the table categorylinks is build).
This is actually The Right Thing in most cases, as it causes images to be listed
which are only in copyright-categories. But it does lead to some false positives.

Note that it's safe for all wikis to apply this patch, as it has no effect
unless $wgCountCategorizedImagesAsUsed is set in LocalSettings.php; This patch
has been tested with MediaWiki 1.4.1 (CVS-Branch REL1_4), it does not use the
new database schema. Also note that unlike the current version of Unusedimages,
it queries the cur table - there my be performance issues with that, I don't know.

(hm, where do I add the patch? After I submitted the report I guess... we'll see)
Comment 1 Daniel Kinzler 2005-04-08 15:40:06 UTC
Created attachment 408 [details]
patched version of SpecialUnusedimages.php; Only getSQL is changed.
Comment 2 JeLuF 2005-04-10 20:31:26 UTC
Please provide a CVS diff or the exact version number of the file that you
started with.
Comment 3 Ævar Arnfjörð Bjarmason 2005-04-10 20:34:17 UTC
This could also make Special:Unusedimages practically useless on other wikis
that use it to look for images that are in articles.
Comment 4 peter green 2005-04-10 20:40:04 UTC
Ævar thats why he made it a configuration option

mind you the current system of using a normal page does have the advantage of
making it easy to leave comments on avenues of investigation that you have tried
and failed
Comment 5 Daniel Kinzler 2005-04-10 20:43:55 UTC
Created attachment 415 [details]
real patch created using   cvs diff -u SpecialUnusedimages.php
Comment 6 Daniel Kinzler 2005-04-10 20:46:39 UTC
(In reply to comment #4)
> Ævar thats why he made it a configuration option

exactly

> mind you the current system of using a normal page does have the advantage of
> making it easy to leave comments on avenues of investigation that you have tried
> and failed

yes, i'm aware of that. Nothing stops us of still using real pages, i'll upload
the updated list in a few days. But keep in mind that the "real" page has the
disadvantage that it can only be updated after a new dump has been released -
the special page is always up to date. So my point it: why not have both?

Comment 7 JeLuF 2005-04-10 21:29:10 UTC
Fixed in CVS HEAD
Comment 8 JeLuF 2005-04-10 21:40:41 UTC
revoked patch, was erroneously committed to HEAD instead of REL1_4.
Comment 9 JeLuF 2005-04-24 11:27:41 UTC
Patched in CVS HEAD, SpecialUnusedimages.php, rev 1.24
Patched in CVS REL1_4, SpecialUnusedimages.php, rev 1.18.2.1

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links