Last modified: 2014-02-13 03:44:26 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T20476, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 18476 - Cannot filter AbuseLog by filter ID without abusefilter-log-detail
Cannot filter AbuseLog by filter ID without abusefilter-log-detail
Status: REOPENED
Product: MediaWiki extensions
Classification: Unclassified
AbuseFilter (Other open bugs)
unspecified
All All
: Low enhancement with 2 votes (vote)
: ---
Assigned To: Nobody - You can work on this!
http://ru.wikipedia.org/wiki/Special:...
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-04-15 13:55 UTC by AlexSm
Modified: 2014-02-13 03:44 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description AlexSm 2009-04-15 13:55:40 UTC
See URL above with autoconfirmed but not sysop user: 
the field "Filter ID" is missing.

The issue is with this code in SpecialAbuseLog.php:
 if ($this->canSeeDetails())
   $this->mSearchFilter = $wgRequest->getIntOrNull( 'wpSearchFilter' );

Which means that users without abusefilter-log-detail right also cannot filter the AbuseLog by specific filter, which doesn't seem to make sense.
Comment 1 Andrew Garrett 2009-04-15 14:01:07 UTC
It's because users without that right aren't allowed to see which filter matched which edit. They just see "matched a filter", rather than "matched filter X"
Comment 2 aokomoriuta 2010-09-20 00:29:31 UTC
I think "filtering by ID" isn't belong to "detailed log".

Because anyone can find the mathced abusefilter's name (public description) at "Filter description" in the every AbuseLog's entries without abusefilter-log-detail (but with abusefilter-log).
So it's very easy to find "which filter matched which edit".

Additionally, the api result can filter by ID without abusefilter-log-detail.
     No filtering: http://ja.wikipedia.org/w/api.php?action=query&list=abuselog
  filtering by #4: http://ja.wikipedia.org/w/api.php?action=query&list=abuselog&aflfilter=4


This means it's unuseful to hide "filtering by ID" in [[Special:AbuseLog]] to hide something detailed, but only inconvenient.

I agree to comment #0.
This bug should be fixed.
Comment 3 Helder 2011-03-24 21:26:39 UTC
(In reply to comment #2)
> I agree to comment #0.
> This bug should be fixed.

Me too. I was just going to report it because
http://pt.wikipedia.org/w/index.php?title=Especial:AbuseLog&wpSearchFilter=96
is not filtering the list to me on Portuguese Wikipedia.
Comment 4 Mark A. Hershberger 2011-03-24 21:47:47 UTC
For those who are slow (like me), the following will show the problem clearly:

http://en.wikipedia.org/wiki/Special:AbuseLog
  and
http://ru.wikipedia.org/wiki/Special:AbuseLog?uselang=en
  vs
http://pt.wikipedia.org/wiki/Especial:AbuseLog?uselang=en

ptwiki is missing the "Filter ID" field that enwiki and ruwiki have. As a result, on ruwiki, you can see links to examine the details of the filter.
Comment 5 Andrew Garrett 2011-03-25 00:20:14 UTC
The behaviour is by design. I'm open to changing it, though.

The real question is whether or not it makes sense to separate the ability to see which filter a specific edit tripped from the ability to view all edits that tripped a particular filter.
Comment 6 Mark A. Hershberger 2011-03-25 01:02:16 UTC
How is the configuration of ptwiki different from enwiki and ruwiki?  Is it simply that the rights on ptwiki are different than the others?
Comment 7 AlexSm 2011-03-25 03:54:13 UTC
Mark: yes, see bug 17998 which we had to file because of this bug; plus you can compare 
http://pt.wikipedia.org/wiki/Special:ListGroupRights?uselang=en and [[Special:ListGroupRights]]
Comment 8 Mark A. Hershberger 2011-03-25 04:43:12 UTC
(In reply to comment #7)
> Mark: yes, see bug 17998 which we had to file because of this bug;

/me reads bug 17998

Heh, I did say I was slow.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links