Last modified: 2009-04-14 01:27:00 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T20441, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 18441 - rebuildrecentchanges.inc ignores $wgLogRestrictions, adding private logs to RC
rebuildrecentchanges.inc ignores $wgLogRestrictions, adding private logs to RC
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Maintenance scripts (Other open bugs)
1.15.x
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-04-12 22:07 UTC by Dan Jacobson
Modified: 2009-04-14 01:27 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Dan Jacobson 2009-04-12 22:07:16 UTC
In RecentChange.php there is code

 # Don't add private logs to RC!
 if( isset($wgLogRestrictions[$type] ...

However there is no corresponding code in rebuildrecentchanges.inc.
(or they don't go thru a common interface).
So running it will expose what was meant to be hid.
Comment 1 Chad H. 2009-04-13 12:16:37 UTC
Fixed in r49438
Comment 2 Dan Jacobson 2009-04-14 00:54:33 UTC
Oh no, now it doesn't work at all.

Warning: Invalid argument supplied for foreach() in /home/jidanni/mediawiki/maintenance/rebuildrecentchanges.inc on line 131
發生了一個資料庫查詢語法錯誤。
最後一次的資料庫查詢是:
「INSERT  INTO `recentchanges` (rc_timestamp,rc_cur_time,rc_user,rc_user_text,rc_namespace,rc_title,rc_comment,rc_minor,rc_bot,rc_patrolled,rc_new,rc_this_oldid,rc_last_oldid,rc_type,rc_cur_id,rc_log_type,rc_log_action,rc_logid,rc_params,rc_deleted) SELECT  log_timestamp,log_timestamp,log_user,user_name,log_namespace,log_title,log_comment,0,0,1,0,0,0,3,COALESCE(page_id, 0),log_type,log_action,log_id,log_params,log_deleted FROM `user`,`logging` LEFT JOIN `page` ON (log_namespace=page_namespace AND log_title=page_title)   WHERE (log_timestamp > '20090114005018') AND (log_user=user_id) AND (log_type IN())  ORDER BY log_timestamp DESC」
來自於函數「rebuildRecentChangesTablePass3」。
MySQL返回錯誤「1064: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '))  ORDER BY log_timestamp DESC' at line 1 (mysql.transgender-taiwan.org)」。
Comment 3 Chad H. 2009-04-14 01:27:00 UTC
Don't have a damn heart attack...it was just a typo. No need for highest priority and a major severity...

Fixed in r49453.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links