Last modified: 2009-05-17 19:39:11 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T20438, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 18438 - Tweak HTML for preview bar (patch)
Tweak HTML for preview bar (patch)
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Parser (Other open bugs)
1.15.x
All All
: Normal enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch, patch-need-review
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-04-12 16:37 UTC by Happy-melon
Modified: 2009-05-17 19:39 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
patch against r49247 (3.02 KB, patch)
2009-04-12 16:37 UTC, Happy-melon
Details
Updated patch, against r49247 (2.05 KB, patch)
2009-04-17 12:13 UTC, Happy-melon
Details

Description Happy-melon 2009-04-12 16:37:15 UTC
Created attachment 6018 [details]
patch against r49247

Currently it's difficult to effectively customise the appearance of the notice that displays when previewing a page; the h2 "preview" header (and the "previewconflict" header when it appears) is unidentified and appears outside the <div class="previewnote"> that contains the "remember this is only a preview" message.  Changes in this patch:

1) assign IDs for both h2s so they can be identified individually
2) move both <h2>s inside the "previewnote" div so it forms a clearer semantic grouping; move the "text-indent:3em" CSS rule to the inner <p> so it doesn't screw up the h2 indentation
3) use an <hr> instead of a bottom margin; semantically clearer and probably better from an accessibility PoV.
Comment 1 Happy-melon 2009-04-17 12:13:02 UTC
Created attachment 6033 [details]
Updated patch, against r49247

Better patch: previous one was duplicated for some reason (not sure if it would have applied or not), and I forgot to bump $wgStyleVersion.
Comment 2 Siebrand Mazeland 2009-05-17 17:38:35 UTC
(In reply to comment #1)
> Created an attachment (id=6033) [details]

Never, ever add BOMs... (as is in this patch for trunk/phase3/includes/DefaultSettings.php)
Comment 3 Siebrand Mazeland 2009-05-17 17:58:04 UTC
Applied with tweaks in r50702 ($this->isConflict NOT $this->isConflict()!). Please test your patches.
Comment 4 Happy-melon 2009-05-17 18:06:43 UTC
I think this one was from before I got my test wiki off the ground.

BOM??
Comment 5 Siebrand Mazeland 2009-05-17 19:07:51 UTC
(In reply to comment #4)
> I think this one was from before I got my test wiki off the ground.
> 
> BOM??
> 
http://en.wikipedia.org/wiki/Byte-order_mark
Comment 6 Happy-melon 2009-05-17 19:39:11 UTC
:S

So *that's* why the diff marked those lines.  Stupid Windows Notepad...

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links