Last modified: 2010-05-04 15:14:36 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T20408, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 18408 - The upload form should not be visible or linked to for users who don't have the edit right
The upload form should not be visible or linked to for users who don't have t...
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Uploading (Other open bugs)
1.15.x
All All
: Normal minor with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on: 18407
Blocks: 11023
  Show dependency treegraph
 
Reported: 2009-04-09 01:53 UTC by Emufarmers
Modified: 2010-05-04 15:14 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Emufarmers 2009-04-09 01:53:16 UTC
You need the edit right to upload files.  Assuming this is intended behavior, the upload form should not load if you don't have the edit right, and there should not be a link on the toolbox or in Special:Specialpages.
Comment 1 p858snake 2009-06-07 01:11:55 UTC
From my understanding of the user rights [1], The edit shouldn't effect upload permissions, the upload right should be the one thats effecting the permission to upload and thats what should be getting checked against.

[1]. http://www.mediawiki.org/wiki/Manual:User_rights
Comment 2 Bryan Tong Minh 2009-09-25 16:47:35 UTC
(In reply to comment #1)
> From my understanding of the user rights [1], The edit shouldn't effect upload
> permissions, the upload right should be the one thats effecting the permission
> to upload and thats what should be getting checked against.
> 
> [1]. http://www.mediawiki.org/wiki/Manual:User_rights
> 

Uploading requires edit, create and upload rights.
Comment 3 Bryan Tong Minh 2010-05-02 20:34:56 UTC
Fixed in r65818.
Comment 4 heugabel 2010-05-03 22:11:09 UTC
(In reply to comment #2)
> (In reply to comment #1)
> > From my understanding of the user rights [1], The edit shouldn't effect upload
> > permissions, the upload right should be the one thats effecting the permission
> > to upload and thats what should be getting checked against.
> > 
> > [1]. http://www.mediawiki.org/wiki/Manual:User_rights
> > 
> 
> Uploading requires edit, create and upload rights.

not working, i can´t acess the upload page :-(
Comment 5 Bryan Tong Minh 2010-05-04 14:49:17 UTC
Fixed in r65898.
Comment 6 heugabel 2010-05-04 15:13:37 UTC
You must set a submission callback

Backtrace:

#0 /home/xxx/public_html/wiki/includes/specials/SpecialUpload.php(1011): HTMLForm->show()
#1 /home/xxx/public_html/wiki/includes/specials/SpecialUpload.php(200): UploadForm->show()
#2 /home/xxx/public_html/wiki/includes/specials/SpecialUpload.php(179): SpecialUpload->showUploadForm(Object(UploadForm))
#3 /home/xxx/public_html/wiki/includes/SpecialPage.php(572): SpecialUpload->execute(NULL)
#4 /home/xxx/public_html/wiki/includes/Wiki.php(259): SpecialPage::executePath(Object(Title))
#5 /home/xxx/public_html/wiki/includes/Wiki.php(67): MediaWiki->handleSpecialCases(Object(Title), Object(OutputPage), Object(WebRequest))
#6 /home/xxx/public_html/wiki/index.php(116): MediaWiki->performRequestForTitle(Object(Title), NULL, Object(OutputPage), Object(User), Object(WebRequest))
#7 /home/xxx/public_html/vbseo.php(1577): require('/home/xxx/...')
#8 {main}

what? i cant understand this :-) sorry
Comment 7 Derk-Jan Hartman 2010-05-04 15:14:36 UTC
This is related to r65841 instead.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links