Last modified: 2010-05-03 14:42:35 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 18366 - Also commit mail for lock/unlock
Also commit mail for lock/unlock
Product: Wikimedia
Classification: Unclassified
Subversion (Other open bugs)
All All
: Normal enhancement (vote)
: ---
Assigned To: Brion Vibber
: shell
Depends on:
  Show dependency treegraph
Reported: 2009-04-06 11:29 UTC by Siebrand Mazeland
Modified: 2010-05-03 14:42 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Description Siebrand Mazeland 2009-04-06 11:29:20 UTC
Currently lock/unlock does not trigger a mail event. Please configure this, as there are no other easy ways to find out which files have been locked.
Comment 1 Brion Vibber 2009-04-08 21:40:13 UTC
I'd be more inclined to disable locks; they don't seem particularly desirable. :P

Looks like either way will take a pre-lock hook script?
Comment 2 Siebrand Mazeland 2009-04-08 22:03:37 UTC
Don't mind which one is chosen. No locks, means no surprises. Commit mail with locks enabled means one could have known.

Recently Tim locked something in SecurePoll, and I locked something in Collection. I accidentally ran into Tim's lock fixing an i18n issue. I later heard he had announced it on either #wikitech or #mediawiki. I lifted my locks, not certain if Tim has lifted his.
Comment 3 Chad H. 2010-05-03 00:30:22 UTC
I've just checked and nobody has any open locks right now on the repository. I'm with Brion in saying just disable locks entirely.
Comment 4 Aryeh Gregor (not reading bugmail, please e-mail directly) 2010-05-03 14:31:59 UTC
I'm also fine with just disabling locks, if that's possible.  Locking is a surprising feature to me, it's used so uncommonly that it will inevitably cause gotchas.
Comment 5 Chad H. 2010-05-03 14:42:35 UTC
Have edited the pre-lock and pre-unlock hooks to both return 1, blocking the transaction. Locking is no longer a problem.

Note You need to log in before you can comment on or make changes to this bug.