Last modified: 2009-04-06 11:52:49 UTC
Please find patch attached. Can obviously commit myself, but input would be appreciated. Setting up a test environment for this is impossible for me... * split off classes for hooks and session * split i18n file in CollectionCore (24 messages) and Collection (83 from 107) to reduce initial load time and memory consumption
Oh, before I forget... Talked about this with a PediaPress developer at the MediaWiki developer conference.
Created attachment 5992 [details] Patch for Collection extension
Thanks a lot for the patch! But I also talked with Domas at the meet-up who said, more important than the performance issue w/ loading the system message (which will be fixed by changes to core MediaWiki code in a few weeks) is the fact, that lots of PHP code gets loaded each time. Your patch is a very good starting point for this problem, too! But some methods in Collection.hooks.php use static methods from Collection.body.php, so I'll refactor that before I'll commit the changes.
(In reply to comment #3) > Thanks a lot for the patch! > > ... the fact, that lots of PHP code gets > loaded each time. [..] Yes, I saw that it needed more refactoring to separate the various parts of functionality into more classes, but I didn't have the time yesterday in Berlin to completely follow through. I have put a lock on the files in SVN to not allow any changes. If you're certain that my patch will be the basis for the next update in there, I will release the lock. Maybe contact me outside this system to get things sorted out?
P.s. If you have tested the patch as working, I can also just commit it, so you can complete whatever else can be refactored.
No, I'm afraid it contained a few minor bugs. I'll contact you via PM in a few minutes.
Fixed in http://svn.wikimedia.org/viewvc/mediawiki?view=rev&revision=49236 Thanks, Siebrand!
