Last modified: 2010-05-15 15:32:59 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 1823 - patch to LanguageNn.php
patch to LanguageNn.php
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Internationalization (Other open bugs)
1.4.x
All All
: Normal normal with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch, patch-reviewed
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2005-04-05 07:49 UTC by Guttorm Flatabø
Modified: 2010-05-15 15:32 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
patch to LanguageNn.php (26.92 KB, patch)
2005-04-05 07:50 UTC, Guttorm Flatabø
Details
Patch for 1_4 branch _only_ to fix HEAD > 1_4 changes applied, unified 3 lines (6.80 KB, patch)
2005-04-07 08:25 UTC, Guttorm Flatabø
Details
Updated patch, after chatting with avar (9.79 KB, patch)
2005-04-07 19:44 UTC, Guttorm Flatabø
Details

Description Guttorm Flatabø 2005-04-05 07:49:48 UTC
This is a patch to LanguageNn.php made from
http://meta.wikimedia.org/wiki/LanguageNn.php
(maintained by myself).

It has been made with Scite and TortoiseCVS + WinMerge (unified, 3 lines).

Many changes (especially many of those to MagicWords) are only white space changes.

I have reinserted 'googlesearch' because the version in Language.php does not
include Yahoo search, the google part however, is identical to the one in
Language.php.

This patch is only meant for the 1.4 branch and is patched against
LanguageNn.php 1.8.2.4, patch for 1.5 will follow when official release is nearer.

I have not tested this on a local installation.

It should be deployed to the Wikimedia servers, and the Mediawiki namespace
should not be initialized.
Comment 1 Guttorm Flatabø 2005-04-05 07:50:37 UTC
Created attachment 402 [details]
patch to LanguageNn.php
Comment 2 Ævar Arnfjörð Bjarmason 2005-04-05 13:35:44 UTC
I applied it to REL1_4 and HEAD after numerous fixes, in the future  submit one
that:
* Is not Wiki(media|pedia)-centric, 'Monobook.css' is should be empty, and
message should not make urls like <a href="/wiki/{{PAGENAME}}"> .. which are
bound fail outside Wikimedia sites.
* Validates as XHTML, 'noarticletext' didn't.
* Make sure it's not redundant, the modifications to $wgDefaultUserOptions for
example didn't do anything at all, you need to actually change date() and co.
for anything like that to work, but even then date => 0 should always be the
default option. (this was in the file already though so I don't know if you're
responsible :=)
Comment 3 Guttorm Flatabø 2005-04-06 10:07:32 UTC
Thanks for the check and fix and all!
I have some issues though:
* Looks like you have applied HEAD changes to 1_4: removed 'all',
'allpagesformtext1', 'allpagesformtext2', 'allpagesnamespace' and
'confirmcheck', added 'undelete_short1', and changed name of 'allpagesnamespace'
to 'allinnamespace'.
* As far as I can see 'noarticletext' fail to validate as XHTML because
MediaWiki doesn't make correct XHTML when parsing (correct word?) the bulleted
list ("*"). The message is as such in perfectly correct wikisyntax. This is a
MediWiki-wise problem not LanguageNn.php-wise problem.
* Why did you revert the 'nonefound' message to an earlier version (or did
you?), the newer is better.
* The use of "localurl" is good, but isn't "localurle" even better?
* I have tried to reinsert the date options, however I'm not quite sure how it
works.
* Why should default user option for dates always be "0"?
* "." (dot) is the old standard for thousands separator, " " (space) is the new,
I have replaced the dot with a space and hope it works.

Please see attempt at fixing these issues at:
http://meta.wikimedia.org/w/index.php?title=LanguageNn.php&diff=0&oldid=116149

(In reply to comment #2)
> * Is not Wiki(media|pedia)-centric, 'Monobook.css' is should be empty, and
> message should not make urls like <a href="/wiki/{{PAGENAME}}"> .. which are
> bound fail outside Wikimedia sites.
Indeed, agreed. :-)

> * Validates as XHTML, 'noarticletext' didn't.
See comment above, I don't want to fix MediaWiki's parsing.

> * Make sure it's not redundant, the modifications to $wgDefaultUserOptions for
> example didn't do anything at all, you need to actually change date() and co.
> for anything like that to work, but even then date => 0 should always be the
> default option. (this was in the file already though so I don't know if you're
> responsible :=)
I was copied from LanguageIs.php actually:-), but I see what you mean and have
tried to fix it.
Comment 4 Guttorm Flatabø 2005-04-06 13:50:47 UTC
I've read your mail to wikitech-l where it is pretty clear that $wgDateFormats
wont work for nn in 1_4, so then that's "clear to me", will implement it in my
patch for 1_5, later.
Comment 5 Guttorm Flatabø 2005-04-07 08:00:41 UTC
Re (by myself): "* Why did you revert the 'nonefound' message to an earlier
version (or did
you?), the newer is better."

I see that you didn't revert this message, it was simply not patched, even
though it was included in my patch.
Comment 6 Guttorm Flatabø 2005-04-07 08:25:56 UTC
Created attachment 404 [details]
Patch for 1_4 branch _only_ to fix HEAD > 1_4 changes applied, unified 3 lines

This is a small patch to fix the aforementioned errors, mostly the HEAD changes
applied to the 1_4 branch version of the file. I've made it with Scite,
Tortoise CVS and Winmerge.

Please _only_ apply to 1_4 (LanguageNn.php 1.8.2.5), I will provide a patch for
HEAD later.
Comment 7 Guttorm Flatabø 2005-04-07 19:44:12 UTC
Created attachment 405 [details]
Updated patch, after chatting with avar

Removed <div> among other changes.
Comment 8 Ævar Arnfjörð Bjarmason 2005-04-07 22:54:41 UTC
Committed it to REL1_4, some comments though, nn. has chosen to use "Fil" for
NS_IMAGE and "Fildiskusjon" for NS_IMAGE_TALK (which means "File" and
"File_talk"), this might cause some trouble in the future if there's ever a
"File:" namespace.

Also, I changed " " in formatNum to "&nbsp;".

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links