Last modified: 2005-04-10 19:53:04 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T3820, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 1820 - OS-detection in EasyTimeline.pl fails on Mac OS X
OS-detection in EasyTimeline.pl fails on Mac OS X
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
EasyTimeline (Other open bugs)
unspecified
Macintosh Mac OS X 10.3
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2005-04-04 19:47 UTC by Schnargel
Modified: 2005-04-10 19:53 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Schnargel 2005-04-04 19:47:59 UTC 
In EasyTimeline.pl the line
  if ($OS =~ /win/i)
in sub SetImageFormat matches "darwin", which is returned by OS X, assigning it Windows $fmt and $pathseparator but it should be the Linux 
ones.

(Looking closer at the following lines it appears that $pathseparator doesn't get set at all if there's no OS detected)
Comment 1 JeLuF 2005-04-05 21:26:30 UTC 
Fixed in CVS HEAD, revision 1.13

$pathseparator is always set, because the else branch is always executed when
the if-condition doesn't match.
Comment 2 Schnargel 2005-04-05 21:36:56 UTC 
Sorry that was my fault about the pathseparator. The issue is still:

In EasyTimeline.pl the line
  if ($OS =~ /win/i)
in sub SetImageFormat matches "darwin", which is returned by OS X, assigning it Windows $fmt and $pathseparator but it should be the Linux 
ones.
Comment 3 JeLuF 2005-04-10 19:53:04 UTC 
Bug has been fixed in CVS. See
r1=1.12&r2=1.13">http://cvs.sourceforge.net/viewcvs.py/wikipedia/extensions/timeline/EasyTimeline.pl?r1=1.12&r2=1.13
Please reopen  if you have checked the new version and problem still exists.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links