Last modified: 2010-07-04 17:19:33 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T20176, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 18176 - Hard coded text in AbuseFilter
Hard coded text in AbuseFilter
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
AbuseFilter (Other open bugs)
unspecified
All All
: High enhancement (vote)
: ---
Assigned To: Andrew Garrett
http://test.wikipedia.org/wiki/Specia...
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-03-26 10:12 UTC by Purodha Blissenbach
Modified: 2010-07-04 17:19 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Purodha Blissenbach 2009-03-26 10:12:38 UTC
There are some short message strings not i18nable in
Extension:Abusefilter which mainly appear as a reply
to the filter load and syntax check and test filter
buttons:
* No syntax errors.
* Syntax error: (translatable message follows)
* BADSYNTAX
maybe more.
Comment 1 Siebrand Mazeland 2009-06-01 15:42:52 UTC
* edit.js: changeText( el, 'Syntax error: '+errorData[0] );
* edit.js: changeText( el, 'No syntax errors.' );
* AbuseFilter.class.php: return 'BADSYNTAX';
* AbuseFilter.class.php: return 'SYNTAXERROR';
* AbuseFilter.class.php: return $result ? 'MATCH' : 'NOMATCH';
Comment 2 Andrew Garrett 2009-06-03 15:14:30 UTC
BADSYNTAX, SYNTAXERROR, MATCH and NOMATCH should never be displayed in the UI. If they are, then that's a bug.
Comment 3 Siebrand Mazeland 2009-06-03 15:22:15 UTC
Updated summary
Comment 4 Andrew Garrett 2009-07-16 17:07:56 UTC
(batch change)

Minor bugs that nevertheless need looking into
Comment 5 Andrew Garrett 2009-07-17 13:53:10 UTC
Resolved with r53395. Thanks for the report.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links