Last modified: 2013-06-18 16:24:15 UTC
In DefaultSettings.php please document $wgExportAllowListContributors what does. (Does it still do it too?!)
I mean: In DefaultSettings.php please document what $wgExportAllowListContributors does. (Does it still do it too?!)
Done in r48852
I'm sorry but I'm afraid this all must be just a remnant of something from the past, as all I can find is find|xargs grep -inH listauthors ./maintenance/fuzz-tester.php:1215: 'listauthors' => wikiFuzz::chooseInput( array("", "0", "-1", wikiFuzz::makeFuzz(2)) ), ./includes/specials/SpecialExport.php:128: $list_authors = $wgRequest->getCheck( 'listauthors' ); Hence the unused code should all be removed, no?
Reclosing, this does do stuff. Look in Export.php. Please don't reopen.
OK, but there is no such checkbox: $list_authors = $wgRequest->getCheck( 'listauthors' ); so that will always fail. And then you throw that answer away anyway, with: if ( !$this->curonly || !$wgExportAllowListContributors ) $list_authors = false ; no?
Well, at least don't check the nonexistent checkbox.
In any case $list_authors has no place that it will be set to true.
I swear you are making a big mistake. Please check the above three comments and reclose. No point in documenting it in DefaultSettings if it can never affect anything.
I believe, although not completely sure that it effects this checkbox "Include only the current revision, not the full history" on special export.
It could be a 'hidden' option (no checkbox, but available as a get parameter if you know its name), Special:Export has several of these. Instead of removing the do_list_authors code for being unused, please consider applying the patch at bug 16082.
Edited summary for easier parsing.
Anyway, there are only two line with... $ find *|fgrep -v .svn|xargs grep -l listauthors|xargs grep -c listauthors includes/specials/SpecialExport.php:1 maintenance/fuzz-tester.php:1
This is most certainly NOT unused, you just fail at searching. Here's how it works: 1) User visits Special:Export, and chooses to only get the current revision. 2) User somehow manages to add &listauthors=1 to the GET request (having a checkbox would be nice for this). 3) Providing that $wgExportAllowListAuthors is true, the export interface will return a list of all authors to the page, even though it is only returning the top revision. Not entirely sure what the software does with this list upon importing into another wiki, etc., as of yet, but I'm assuming it is used to fill out the history to some extent -- will have to do some more in-depth review of this
Well, you've documented $wgExportAllowListContributors, but without also somewhere documenting >2) User somehow manages to add &listauthors=1 to the GET request (having a > checkbox would be nice for this). there will be little chance anybody will figure it out. I'm not saying you need to necessarily clutter the interface with a checkbox, but do document this secret parameter somewhere...
Checkbox added in rev 103314 (if the admins have enabled the option globally, it might as well show up in the form).
Seems like nothing is left to be done. The global is documented, we even have a checkbox for user to use that function :-]