Last modified: 2010-08-09 06:40:43 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T20164, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 18164 - Search URLs became a mess
Search URLs became a mess
Status: RESOLVED WORKSFORME
Product: MediaWiki
Classification: Unclassified
Search (Other open bugs)
unspecified
All All
: Normal enhancement with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
http://de.wikipedia.org/w/index.php?n...
: easy
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2009-03-26 00:34 UTC by Melancholie
Modified: 2010-08-09 06:40 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Melancholie 2009-03-26 00:34:30 UTC 
Our search URLs became a mess by the latest code update:
1. The special page name isn't localized anymore (for all searches)!
    Example: Spezial:Search instead of Spezial:Suche.
2. &fulltext=1 got doubled.
    Example: &fulltext=Advanced+search&fulltext=Erweiterte+Suche
3. Parameters do not show any proper sort order anymore.

Sidebar search:
=> http://de.wikipedia.org/w/index.php?title=Spezial%3ASearch&search=search-url-bug-showcase&fulltext=Volltext
==> title, search, fulltext: OK (but "Search" is English!)

#search:
=> http://de.wikipedia.org/w/index.php?search=search-url-bug-showcase&ns0=1&title=Spezial%3ASuche&fulltext=Search&fulltext=Volltext
==> search, ns0, title, fulltext, fulltext (leave title as first, remove doubled fulltext)
HTML source:
<input name="title" type="hidden" value="Spezial:Suche" /><input name="fulltext" type="hidden" value="Search" /><input type="submit" value="Volltext" name="fulltext" />

#powersearch:
=> http://de.wikipedia.org/w/index.php?ns0=1&search=search-url-bug-showcase&title=Spezial%3ASuche&fulltext=Advanced+search&fulltext=Erweiterte+Suche
==> ns0, search, title, fulltext, fulltext (ns0 first? leave title as first. ...remove doubled fulltext)
HTML source:
<input name="title" type="hidden" value="Spezial:Suche" />
<input name="fulltext" type="hidden" value="Advanced search" />
<input type="submit" value="Erweiterte Suche" name="fulltext" />

If the doubled &fulltext= should have been intended for some kind of tracking, please use only *one* &fulltext= anyway, but instead use:
&fulltext=1 if 'Search'
*or*
&fulltext=2 if 'Advanced+search'
Comment 1 Melancholie 2009-03-26 00:42:00 UTC 
Note: 'title' should be retained coming first (code move just to be reverted), as its done this way for all other URLs; always provide a consistent scheme.
Example: http://de.wikipedia.org/w/index.php?title=Beispiel_(Rhetorik)&diff=56515972&oldid=56231682
Comment 2 Melancholie 2009-03-26 00:50:30 UTC 
@Localisation:
   possibly introduced with r47773?
   Maybe change SpecialPage::getTitleFor('search')
   to
   SpecialPage::getTitleFor('Search')
   (s->S)?
Comment 3 Melancholie 2009-03-26 01:00:21 UTC 
Compare r38436.
@fulltext: if its a tracking thing, removing name="fulltext" from the submit type input works.
Comment 4 Karun 2010-02-06 10:56:07 UTC 
Appears to have been fixed already. Tested 06.02.2010 9.46pm GMT+10.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links