Last modified: 2011-03-13 18:06:37 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T20069, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 18069 - CSS valid code
CSS valid code
Status: RESOLVED WONTFIX
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
1.15.x
All All
: Lowest trivial (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch, patch-need-review
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-03-20 18:10 UTC by Stefano Codari
Modified: 2011-03-13 18:06 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Corrected two errors for CSS 3 and one for CSS 2.1 (606 bytes, patch)
2009-03-20 18:10 UTC, Stefano Codari
Details

Description Stefano Codari 2009-03-20 18:10:41 UTC
Created attachment 5943 [details]
Corrected two errors for CSS 3 and one for CSS 2.1

The Monobook skin is not valid CSS 2.1 or 3

I've done two corrections (see the patch) and now it's valid CSS 3 but not 2.1 because of the overflow-x:hidden that is present only in CSS 3.
Comment 1 Chad H. 2009-04-27 14:52:57 UTC
Fixed the colors in r49959. Not touching overflow-x because it's valid CSS3.
Comment 2 Aryeh Gregor (not reading bugmail, please e-mail directly) 2009-04-27 17:26:11 UTC
Reopening, recommend revert.  darkblue and orange are both valid CSS3 colors:

http://www.w3.org/TR/css3-color/#svg-color

They've been interoperably implemented since forever in all browsers, and "orange" and "darkblue" are much more comprehensible than their hex-color equivalents.  Broken validators that disagree with the specs should be ignored.
Comment 3 Stefano Codari 2009-04-27 19:12:28 UTC
(In reply to comment #2)
> Reopening, recommend revert.  darkblue and orange are both valid CSS3 colors:
> 
> http://www.w3.org/TR/css3-color/#svg-color
> 
> They've been interoperably implemented since forever in all browsers, and
> "orange" and "darkblue" are much more comprehensible than their hex-color
> equivalents.  Broken validators that disagree with the specs should be ignored.
> 

I used the official W3C CSS Validator, see this result:

http://jigsaw.w3.org/css-validator/validator?uri=http%3A%2F%2Fen.wikipedia.org&profile=css3&usermedium=all&warning=1&lang=en
Comment 4 Aryeh Gregor (not reading bugmail, please e-mail directly) 2009-04-28 00:00:28 UTC
The official CSS validator doesn't recognize pretty much any CSS3.  That doesn't mean we should refuse to use CSS3 when it's stable and interoperably implemented.  In this case, the CSS3 has the notable benefit of being easier to read: it's especially impossible for anyone to figure out that "#FFA500" means "orange" without checking it out (#00008B is admittedly more comprehensible).  Shutting up validators that are demonstrably *wrong* is not a legitimate reason to do anything, especially if it has negative effects.
Comment 5 Chad H. 2009-05-03 21:37:18 UTC
Reverted in r50160 per comments on code review. WONTFIX.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links