Last modified: 2009-05-11 23:23:30 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T20068, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 18068 - Privileged users should be allowed to see any diffs against deleted edits
Privileged users should be allowed to see any diffs against deleted edits
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Page deletion (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-03-20 17:57 UTC by FT2
Modified: 2009-05-11 23:23 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description FT2 2009-03-20 17:57:44 UTC
Example history:
http://en.wikipedia.org/w/index.php?title=Christopher_Walken&offset=20090318235900&limit=9&action=history

Example diff from that history (manually created link):
http://en.wikipedia.org/w/index.php?title=Christopher_Walken&diff=next&oldid=278156800


A user who has access to show/hide a revision, should be able to see diffs involving that revision which may be (for example) submitted to oversight, or some project's Arbcom.

At present an oversighter can see the edit details, or amend visibility, but cannot look at diffs involving that revision (eg to see what was added or removed, if reviewing the edit or the suppression). They get the same error that public users would get.

Typical scenario - a user reports a diff for suppression (eg due to privacy breach), the first oversighter to see the request suppresses the edit, and another oversighter wishes to review the edit of verify the action was appropriate -- the diff supplied will no longer work.


PREFERRED BEHAVIOR: if the user would have show/hide access to both revisions involved in the diff, they should have acess to the diff itself, and it should be linked as normal in contribs and history for them. Instead, when they open the diff, the diff page should indicate if the revision text of either edit is hidden or suppressed (and whether public or sysops):

Ie, where it currently states 

> You cannot view this diff because one of the revisions has been removed from 
> the public archives. There may be details in the deletion log", 

if the user /can/ see the text of both revisions, the box should say 

> Parts of this revision have been hidden from general viewing. 
> Details are as follows:
> Left revision: visible to all users
> Right revision: Hidden from public and from sysops ("privacy breach")
Comment 1 FT2 2009-03-20 18:00:23 UTC
> "another oversighter wishes to review the edit of verify the 
> action was appropriate"

of -> or (typo)
Comment 2 Aaron Schulz 2009-03-22 05:47:52 UTC
RevisionDelete has a (diff) link for change, you can use that.
Comment 3 FT2 2009-03-22 06:26:24 UTC
Apologies for reopening. But the two aren't at all identical. A lot of the time one is sent links between two (effectively) arbitrary diffs, not two consecutive ones. The hard link to /this/ diff in RevisionDeleted itself doesn't make up for the fact that one cannot see the diff between a hidden edit and another previous or subsequent edit. 

At present one cannot for example see a diff between a revision where text was hidden, and (for example) the diff 3 edits ago before the 3 vandalism edits, or before some edit war, or as supplied by users. One can only see the one consecutive diff. 

Normal diff function is needed in history, contribs and generally - in other words if a user can see the text of any two revisions individually, then RevDel should not block them selecting or seeing a diff between the two revisions, or seeing diff links in contribs + history.
Comment 4 Aaron Schulz 2009-03-22 07:17:37 UTC
Changing summary
Comment 5 Aaron Schulz 2009-03-22 13:45:17 UTC
Tweaks in r48682
Comment 6 Aaron Schulz 2009-03-26 22:26:17 UTC
Done in r48902, with confirmation links
Comment 7 FT2 2009-05-11 19:17:30 UTC
Reopening - can this be fixed also for oversighters viewing suppressed revisions/diffs as well?

At present the click-through fix of [[Mediawiki:Rev-deleted-unhide-diff]] only works for unsuppressed editors and admins, but the same applies to suppressed edits and oversighters.

Thanks :)
Comment 8 FT2 2009-05-11 19:29:31 UTC
Example: 

http://en.wikipedia.org/w/index.php?oldid=284084867> is a revision that has been suppressed according to Oversight-l. The page just states "This page revision has been removed from the public archives. There may be details in the deletion log", as opposed to the more usual [[Mediawiki:rev-deleted-unhide-diff]] ("One of the revisions of this diff has been removed from the public archives... you can still [$1 view this diff] if you wish to proceed". 

Had the item been admin deleted, a visiting administrator would be shown the message advising them that the content was deleted but that they could click through a link to view the deleted material. Apparently this isn't done for oversighters clicking suppressed material. 

To fix this, [[Mediawiki:Rev-deleted-no-diff]], [[Mediawiki:Rev-deleted-text-permission]], and [[Mediawiki:Rev-deleted-text-view]] would need to take a $1 parameter for the click-through link, as [[Mediawiki:Rev-deleted-unhide-diff]] does.
Comment 9 FT2 2009-05-11 19:30:08 UTC
(I think?)
Comment 10 Aaron Schulz 2009-05-11 23:23:30 UTC
'oldid' viewing of old versions (not diffs) do not have this quick link live at the moment. This was fixed ages ago, but hasn't been synced.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links