Last modified: 2009-03-25 07:54:01 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T19984, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 17984 - Allow restriction of access to Special:Code
Allow restriction of access to Special:Code
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
CodeReview (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Aaron Schulz
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-03-15 00:50 UTC by Simon Walker
Modified: 2009-03-25 07:54 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
'codereview-use' user right patch (1.55 KB, patch)
2009-03-15 00:50 UTC, Simon Walker
Details

Description Simon Walker 2009-03-15 00:50:16 UTC
Created attachment 5929 [details]
'codereview-use' user right patch

Let group A be the group of users allowed to access a wiki. Let B be a group of developers, where B is a subset of A.

If access to the subversion repositories was closed to only users in B, then those in A can't access subversion. However, they can access the code via Special:Code. Access to Special:Code should be restricted in closed environments.

I've produced a patch to restrict access to Special:Code in the same manner as Special:RepoAdmin is restricted (by the addition of a new user right). However, by default this extra user right ( codereview-use ) is assigned to *, so nothing should change. This does allow the option of restricting the access in the above situation though.

I'm using this on a private wiki that I'm administering, and it seems to work, so I thought I'd let other people use the code too.
Comment 1 Aaron Schulz 2009-03-18 21:15:12 UTC
Done in r48538 (related to r48537)
Comment 2 Brion Vibber 2009-03-25 00:54:54 UTC
Don't forget there's an API module, which includes an interface for pulling diffs. This presumably needs the same access check...
Comment 3 Aaron Schulz 2009-03-25 07:54:01 UTC
(In reply to comment #2)
> Don't forget there's an API module, which includes an interface for pulling
> diffs. This presumably needs the same access check...
> 

Done in r48777

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links