Last modified: 2014-09-24 01:27:22 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T19978, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 17978 - non-existing subpage in MediaWiki namespace show empty div with style
non-existing subpage in MediaWiki namespace show empty div with style
Status: REOPENED
Product: MediaWiki
Classification: Unclassified
Interface (Other open bugs)
unspecified
All All
: Low enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
http://en.wikipedia.org/wiki/MediaWik...
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-03-14 12:49 UTC by Umherirrender
Modified: 2014-09-24 01:27 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
fix the empty div (493 bytes, patch)
2010-06-04 18:02 UTC, Umherirrender
Details

Description Umherirrender 2009-03-14 12:49:54 UTC
When look at a non-existing subpage in MediaWiki namespace the message [[MediaWiki:Noarticletext]] is not shown, but "<div class="noarticletext"></div>" is add to the HTML. The problem is, that css is declared for that class and so the div has a style. Thats look scary, because there is no text in it.

Please remove that div or show the message on subpages in MediaWiki namespace. Thanks.
Comment 1 Umherirrender 2010-06-04 18:02:48 UTC
Created attachment 7428 [details]
fix the empty div
Comment 2 DieBuche 2011-07-07 08:21:48 UTC
Cant reproduce. noarticletext is not styled & the message is always shown to me
Comment 3 Umherirrender 2011-08-08 17:44:18 UTC
(In reply to comment #2)
> Cant reproduce. noarticletext is not styled & the message is always shown to me

* Go to an mediawiki page without content, like http://translatewiki.net/wiki/MediaWiki:Bug17978
* see an small box without content (in IE8)
Comment 4 DieBuche 2011-08-08 20:06:02 UTC
I don't see it in IE8 either. Could you add a screen?
Comment 5 Umherirrender 2011-08-09 17:46:48 UTC
(In reply to comment #4)
> I don't see it in IE8 either. Could you add a screen?

Sorry. I see it in monobook skin and also with firefox.

http://translatewiki.net/wiki/MediaWiki:Bug17978?useskin=monobook

I hope, you will see it now. When not, I can add a screenshot at weekend.
Comment 6 Krinkle 2011-08-14 21:46:20 UTC
It's also in Vector. Look at the HTML source, not at the browser viewport.
Comment 7 Umherirrender 2011-08-15 17:02:55 UTC
(In reply to comment #6)
> It's also in Vector. Look at the HTML source, not at the browser viewport.

Yes, but it is not styled and so there is no (visible) problem. So you can fix this, by removing the emtpy div or by removing the stylesheet, or both.
Comment 8 Krinkle 2011-08-24 23:24:25 UTC
(In reply to comment #7)
> (In reply to comment #6)
> > It's also in Vector. Look at the HTML source, not at the browser viewport.
> 
> Yes, but it is not styled and so there is no (visible) problem. 

No, that depends. We cannot imply that a div doesn't have styling. Sites, users, extensions and gadgets may apply styling at any time. It applies to Vector just as much as any other skin.

Fix by removing the element where it should not be outputted.
Comment 9 Robin Pepermans (SPQRobin) 2011-09-05 02:21:56 UTC
It could be an idea to change the default MediaWiki message to use a different div (e.g. class='mw-defaultmessage' or something), and reserve 'noarticletext' for when there's *really* no text. It doesn't really make sense to show a completely empty page, imho.
Comment 10 Umherirrender 2012-04-05 19:14:14 UTC
(In reply to comment #9)
> It could be an idea to change the default MediaWiki message to use a different
> div (e.g. class='mw-defaultmessage' or something), and reserve 'noarticletext'
> for when there's *really* no text. It doesn't really make sense to show a
> completely empty page, imho.

That is possible, but not part of this bug, because here is the problem, that the div is added, when there is nothing to wrap (Go to [[MediaWiki:Not exist]], there is no hint to missing articletext)

Title::getDefaultMessageText returns false and that is than convertet to an emtpy string and outputted. Maybe add a message, if Title::getDefaultMessageText returns false or output 'noarticletext'.
Comment 11 Sumana Harihareswara 2012-05-22 13:44:55 UTC
(Removed keywords because patch is obsolete.)

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links