Last modified: 2010-05-15 15:29:33 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 178 - Most image options shouldn't depend on $wgUseImageResize
Most image options shouldn't depend on $wgUseImageResize
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
File management (Other open bugs)
1.3.x
PC Windows XP
: Low enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on: 689
Blocks:
  Show dependency treegraph
 
Reported: 2004-08-19 17:58 UTC by Alan
Modified: 2010-05-15 15:29 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Alan 2004-08-19 17:58:54 UTC
I ran into this on a local install of MediaWiki.  With the default setting (in
1.3.1 anyway) of $wgUseImageResize = false, including image options like this:

[[Image:some_image.jpg|frame|center|Some caption]]

will not work.  The problem is in makeImageLinkObj() in Skin.php: options are
not processed unless $wgUseImageResize == true, despite the fact that only the
thumb and __px options are related to image resizing.

The workaround is of course to set $wgUseImageResize = true in
LocalSettings.php, but it's not very intuitive that the way to enable image
alignment and framing is to set a resize flag.
Comment 1 Rowan Collins [IMSoP] 2004-10-03 18:10:41 UTC
There appears to be a seperate $wgUseImageMagick; we may be able to rename
$wgUseImageResize to $wgExtendedImageSyntax, and make sure actual resizing can't
be done if $wgUseImageMagick is false. 
Comment 2 JeLuF 2004-10-03 21:12:39 UTC
$wgUseImageMagick determins whether the built-in GD library is used for scaling
or whether the ImageMagick command line tool is used.
Comment 3 Rowan Collins [IMSoP] 2004-10-03 21:19:13 UTC
Ah, I thought I might be missing something. Is there any reason not to just
always enable the extended image syntax? We could just put checks on
$wgUseImageResize round bits of code that actually do image resizing. This could
also allow us to have the fallback ability somebody asked for of setting height=
and width= attributes on the image without actually generating a thumbnail.
Comment 4 JeLuF 2004-10-12 10:58:09 UTC
Fixed in CVS HEAD, Skin.php rev 1.295

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links