Last modified: 2005-12-12 02:59:15 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T3778, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 1778 - Watchlist says "120000 total pages edited since cutoff"
Watchlist says "120000 total pages edited since cutoff"
Product: MediaWiki
Classification: Unclassified
Special pages (Other open bugs)
All All
: Normal normal with 2 votes (vote)
: ---
Assigned To: Nobody - You can work on this!
Depends on:
Blocks: code_quality
  Show dependency treegraph
Reported: 2005-03-29 21:02 UTC by Aphaia
Modified: 2005-12-12 02:59 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Description Aphaia 2005-03-29 21:02:01 UTC
Special pages bug, Wikimedia site specific or bug of MediaWiki 1.4.0

Watchlist says "120000 total pages edited since cutoff" not depending the real
number of edits. Found on English Wikiquote and Japaense Wikipedia. Perhaps on
other sites, too.
Comment 1 Michael Madsen 2005-04-23 14:21:44 UTC
This is due to a developer error - the watchlist queries have been 
removed to save time, and instead been replaced with an estimate 
that says 40000*days edits.

The bug is in SpecialWatchlist.php:

                // Excessively expensive query removed and replace 
with an 
estimate that's roughly the same on
                // Query below was more expensive than the real 
                $docutoff = "AND cur_timestamp > '$cutoff'";
                $sql = "SELECT COUNT(*) AS n FROM $cur WHERE 
                $res = $dbr->query( $sql, $fname );
                $s = $dbr->fetchObject( $res );
                $npages = $s->n;
                $npages = 40000 * $days;

To fix, remove $npages = 40000 * $days; and un-comment the code 
directly above.
Comment 2 crestfall 2005-05-22 02:08:41 UTC
I suggest that only the line:

$docutoff = "AND cur_timestamp > '$cutoff'";
be uncommented. This will disable the count query but unbork the SQL.
Comment 3 John Overmars 2005-05-24 11:37:53 UTC
on our wiki (display notices enabled in PHP) there is also a notice displayed:
"undefined variable: docutoff in <strong>C:\WWW\wiki\includes\SpecialWatchlist.php</strong> on line <strong>173</strong>"
Comment 4 Michael Keppler 2005-06-10 20:33:38 UTC
In 1.5 CVS the page count is calculated by a query again, therefore closing as
Comment 5 Brion Vibber 2005-06-10 23:15:53 UTC
The whole bit's rather crappy and needs cleanup and merging of fixes from live branch, 
Comment 6 Jeffrey Quisenberry 2005-06-26 23:58:45 UTC
en:Wikiquote has just been updated to 1.5beta1, and not only does this problem
still exist there, but Special:Watchlist user watchlist count now erroneously
includes talk pages, even though it explicitly says "not counting talk pages".
Comment 7 Brion Vibber 2005-12-12 02:59:15 UTC
This debug message got removed some while ago. Resolving FIXED.

Note You need to log in before you can comment on or make changes to this bug.