Last modified: 2010-05-10 17:04:31 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T19762, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 17762 - Show/hide further email conf. options depending on the E-mail features (global) option
Show/hide further email conf. options depending on the E-mail features (globa...
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Installer (Other open bugs)
1.15.x
All All
: Normal enhancement with 1 vote (vote)
: ---
Assigned To: Brion Vibber
: patch, patch-need-review
Depends on: 16257
Blocks:
  Show dependency tree / graph
 
Reported: 2009-03-02 18:55 UTC by Matěj Grabovský
Modified: 2010-05-10 17:04 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Patch for mwroot/config/index.php against rev47942 (4.70 KB, patch)
2009-03-02 18:55 UTC, Matěj Grabovský 		Details
Fixed patch for mwroot/config/index.php against r47942 (4.96 KB, patch)
2009-03-02 20:15 UTC, Matěj Grabovský 		Details
Show Obsolete (1) Add an attachment (proposed patch, testcase, etc.)

Description Matěj Grabovský 2009-03-02 18:55:50 UTC 
Created attachment 5877 [details]
Patch for mwroot/config/index.php against rev47942

I've created a patch for the config/index.php file that hide the "User-to-user e-mail", "E-mail notification about changes" and "E-mail address authentication" options if the "E-mail features (global)" option is set to Disabled. Of course it unhides it when it's set to Enabled.

I just quickly wrote this in school so I'm not sure if it's 100% secure/compatible/working. It was tested in the following browser and in all of them worked:
- Mozilla Firefox 3.0.6 / Win32
- Google Chrome 1.0.154.48 / Win32
- Opera 9.62 / Win32
- Internet Explorer 7.0.6001.18000 / Win32
Comment 1 Matěj Grabovský 2009-03-02 20:15:08 UTC 
Created attachment 5878 [details]
Fixed patch for mwroot/config/index.php against r47942

Fixed unability to change Database type option, sorry.
Comment 2 Matěj Grabovský 2009-03-12 19:41:42 UTC 
Could someone at least review the patch, please?
Comment 3 Brion Vibber 2009-03-12 19:43:44 UTC 
Putting it on my review list.
Comment 4 Dan Jacobson 2009-05-31 01:21:09 UTC 
I haven't tried the patch, but I note currently the line
> "Enabled for changes to user discussion pages, and to pages on watchlists (not recommended for large wikis)", "radio", "enotif_allpages"
is too long and knocks its fellow radio buttons to the left, so they
don't line up with the rest of the form.

This is because config/index.php has developed in the wrong direction.
You know it when you see things like "/* IE hack */"

I would rip out all the complexity and just use old fashioned HTML strict <dl> and <input>s.
<dt>E-mail notification about changes:
    <dd>* Disabled
    <dd>* Enabled for changes to user discussion pages only
    <dd>* Enabled for changes ...
Comment 5 Chad H. 2010-05-10 17:04:31 UTC 
This is done with the new-installer being merged in r66008.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links