Last modified: 2009-02-27 20:28:32 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T19707, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 17707 - "Upload new version of this file" form should use plain text rather than readonly field for destination name
"Upload new version of this file" form should use plain text rather than read...
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Uploading (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Aaron Schulz
http://commons.wikimedia.org/w/index....
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-02-27 18:47 UTC by Brion Vibber
Modified: 2009-02-27 20:28 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Brion Vibber 2009-02-27 18:47:26 UTC
Breaking out from comment on bug 17200:

---- Comment  #10 From Ilmari Karonen  2009-02-04 22:14:33 UTC  [reply] -------

(In reply to comment #4)
> Fixed in r46475

This still has some minor UI issues: the read-only field remains focusable (as
Lupo notes above) and gives no visual indication of being uneditable -- it just
doesn't react to typing, quite probably making some users wonder if their
browser has a bug or something.

We could gray it out with CSS and give it a high tabindex or something, but I
think an even better solution would be to just make the field hidden and
replace it with plain text: that way it's obvious to anyone that it can't be
changed.

-----------

Hidden field + plain text seems like the best solution to me; this avoids the "it looks like a field, but doesn't act like one" while keeping it visibly there for clarity. Might need to confirm it doesn't bork up the JS on the form.
Comment 1 X! 2009-02-27 20:28:32 UTC
Fixed in r47872.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links