Last modified: 2009-10-25 09:03:46 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T19700, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 17700 - Skin.php: $this->getSkinName() calls lowercase skinname.css if $wgCapitalLinks is off
Skin.php: $this->getSkinName() calls lowercase skinname.css if $wgCapitalLink...
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Parser (Other open bugs)
1.15.x
All All
: Normal trivial (vote)
: ---
Assigned To: Nobody - You can work on this!
http://en.wiktionary.org/wiki/Special...
:
: 18320 (view as bug list)
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2009-02-27 12:24 UTC by Splarka
Modified: 2009-10-25 09:03 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Splarka 2009-02-27 12:24:16 UTC 
<link rel="stylesheet" href="/w/index.php?title=MediaWiki:Common.css&amp;usemsgcache=yes...
 <link rel="stylesheet" href="/w/index.php?title=MediaWiki:monobook.css&amp;usemsgcache=yes...

With capitalized links off, getSkinName() passed through Title::makeTitleSafe returns lowercased, eg "monobook.css". Message names always have to be uppercase page names (with some exceptions).

However, this still works for this particular instance, as usemsgcache=yes normalizes the case back to "Monobook.css", and returns the contents... but this is a fragile situation. Several things could break it, and testing skinname.css with $wgCapitalLinks is probably not done on every edit to Skin.php ...?

Probably getSkinName() should be ucfirst'd there?
Comment 1 Chad H. 2009-02-27 13:14:35 UTC 
ucfirst() on getSkinName() would be a short-term fix. Ideally, secureAndSplit() should normalize message titles.
Comment 2 Splarka 2009-04-03 05:54:15 UTC 
*** Bug 18320 has been marked as a duplicate of this bug. ***
Comment 3 Alexandre Emsenhuber [IAlex] 2009-10-25 09:03:46 UTC 
This should be fixed in r57558.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links