Last modified: 2009-11-12 22:36:05 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T19662, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 17662 - Customizable default preload/editintro in add-new-section link for Talk page
Customizable default preload/editintro in add-new-section link for Talk page
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Interface (Other open bugs)
1.15.x
All All
: Normal enhancement with 1 vote (vote)
: ---
Assigned To: Robin Krahl
: easy, patch, patch-need-review
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-02-25 07:49 UTC by Anon Sricharoenchai
Modified: 2009-11-12 22:36 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Checks preload and editintro system messages and adds them (1.15 KB, patch)
2009-10-06 19:32 UTC, Robin Krahl
Details
Improves the previous proposed patch (1.79 KB, patch)
2009-10-06 20:08 UTC, Robin Krahl
Details

Description Anon Sricharoenchai 2009-02-25 07:49:51 UTC
Suggestion to change the add-new-section link on the top of Talk page (which appear as a plus sign "+" beside the edit link).

== Current status ==
* The link look like {{fullurl:...|action=edit&section=new}}

== Suggestion for improvement ==
* The link should look like {{fullurl:...|action=edit&section=new&preload=xxx&editintro=yyy}}
* The value "xxx" and "yyy" can be customized in MediaWiki namespace, MediaWiki:talk-new-section-link-preload and MediaWiki:talk-new-section-link-editintro, for example.
* If the page MediaWiki:talk-new-section-... is empty, then the link should look like {{fullurl:...|action=edit&section=new}}, which is the same as current status
Comment 1 Robin Krahl 2009-10-06 19:32:33 UTC
Created attachment 6636 [details]
Checks preload and editintro system messages and adds them

This proposed fix searches the system messages “talk-addsection-preload” and “talk-addsection-editintro” and loads them if they exist. 

Maybe it would be nice to try loading “talk-addsection-…-<namespace>” (e. g. “talk-addsection-preload-0”) and then (if it doesn’t exist) try loading the standard “talk-addsection-…”. Comments?
Comment 2 Robin Krahl 2009-10-06 20:08:37 UTC
Created attachment 6638 [details]
Improves the previous proposed patch

Adds the two messages to MessagesEn.php (value ''). So I can check whether the system messages are '' (==> no editintro/preload) or not.
Comment 3 Anon Sricharoenchai 2009-10-07 03:44:49 UTC
One may notice that, why not put the preload like,
{{fullurl:...|action=edit&section=new&preload=mediawiki:talk-addsection-preload&editintro=mediawiki:talk-addsection-editintro}}?
Well, this will always prevent the user from editing the preload template, which is not desired.

(In reply to comment #1)
> 
> Maybe it would be nice to try loading “talk-addsection-…-<namespace>” (e.
> g. “talk-addsection-preload-0”) and then (if it doesn’t exist) try
> loading the standard “talk-addsection-…”. Comments?
> 

Good, this is very useful.
Comment 4 Bryan Tong Minh 2009-11-12 22:36:05 UTC
Applied in r58980.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links