Last modified: 2010-05-15 16:03:31 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T19649, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 17649 - COUNT(*) when editing page to check if the page is deleted
COUNT(*) when editing page to check if the page is deleted
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Database (Other open bugs)
1.13.x
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2009-02-24 14:18 UTC by David Tabachnikov
Modified: 2010-05-15 16:03 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add a $doCount flag to Title::isDeleted, and set it to "FALSE" for Edit Page and Special:Upload. (2.04 KB, patch)
2009-02-24 14:18 UTC, David Tabachnikov 		Details
Add an attachment (proposed patch, testcase, etc.)

Description David Tabachnikov 2009-02-24 14:18:53 UTC 
Created attachment 5860 [details]
Add a $doCount flag to Title::isDeleted, and set it to "FALSE" for Edit Page and Special:Upload.

When editing a page, isDeleted is called, which counts the amount of revisions in the archive for that article. There's no reason to count that, if all we want to see is if the page is deleted or not. And on pages with a lot of deleted revisions (such as bot histories), it can become very slow.

This patch adds a flag to isDeleted that controls whatever to see if there are any revisions, or to count the actual revisions, depending on the usage.
Comment 1 Aaron Schulz 2009-02-24 16:17:43 UTC 
Fixed in r47750
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links